Way more diff data transfered over the wire when using Surface component than plain LV even if rendered html is very similar
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- elixir
- 领域
- backend, performance
调研方向
Start with the SurfaceBulma.Button implementation linked at lib/surface_bulma/button.ex#L97 and compare its rendered output with the plain LiveView templates in the report. Reproduce the favorite? toggle on the stated Surface and LiveView versions, inspect the rendering and diff path, and consider the issue done when equivalent component HTML no longer sends substantially more diff data.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
Can't tell if this is a bug, more likely a flaw or technical debt, but I hope it's not the intended behavior.
Altering a SurfaceBulma.Button disabled attribute (only) produces way too much data and I don't think this has anything to do with the component itself, but rather the rendering engine.
Please note that in both cases (Surface and plain LiveView) the provided code is part of a component in a prepended list of such components, thus only the changed component is sent in each case.
1. Plain LiveView
Template code
<button phx-click="add_favorite" disabled={@card.favorite?} size="large" phx-target={@myself}>Add to Favorites</button>
<button phx-click="remove_favorite" disabled={[email protected]?} size="large" phx-target={@myself}>Remove from favorites</button>
Rendered html
<button phx-click="add_favorite" size="large" phx-target="1">Add to Favorites</button>
<button phx-click="remove_favorite" size="large" phx-target="1" disabled="">Remove from favorites</button>
Diffs when @card.favorite? toggles:
{
"2": {
"5": {
"d": [
[
2
]
]
},
"8": "3"
},
"c": {
"2": {
"4": " disabled",
"7": ""
}
}
}
2. SurfaceBulma.Button
Template code:
<Button click="add_favorite" disabled={@card.favorite?} size="large">Add to Favorites</Button>
<Button click="remove_favorite" disabled={[email protected]?} size="large">Remove from favorites</Button>
Rendered html:
<button phx-click="[["push",{"event":"add_favorite","target":1}]]" type="button" class="button is-large">
Add to Favorites
</button>
<button phx-click="[["push",{"event":"remove_favorite","target":1}]]" type="button" class="button is-large" disabled="">
Remove from favorites
</button>
Diffs when @card.favorite? toggles:
{
"2": {
"5": {
"d": [
[
1
]
]
},
"8": "1"
},
"c": {
"1": {
"3": {
"0": {
"0": {
"0": {
"0": {
"0": " phx-click=\"[["push",{"event":"add_favorite","target":1}]]\"",
"1": "",
"2": " type=\"button\"",
"3": "",
"4": "",
"5": "",
"6": " class=\"button is-large\""
}
}
}
}
},
"4": {
"0": {
"0": {
"0": {
"0": {
"0": " phx-click=\"[["push",{"event":"remove_favorite","target":1}]]\"",
"1": "",
"2": " type=\"button\"",
"3": "",
"4": " disabled",
"5": "",
"6": " class=\"button is-large\""
}
}
}
}
}
}
}
}
How to reproduce it
Suffice changing LiveView code to using SurfaceBulma.Button component (or vice-versa).
The behavior you expected
The size of the diffs should be virtually identical, especially given that nothing except for disabled changes and the rendered html code has the same number of elements in both cases i.e. 1 per button.
Your Environment
Surface: v0.7.4
LiveView: v0.17.9
Elixir: v1.13.4
- 主要语言
- Elixir
- 星标
- 2.1k
- 派生
- 146
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
surface-ui/surface 的其他 Issue
-
难度 1/5 1-3 小时 新手友好度 78/100
surface-ui/surface#634 · 1 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 35/100
surface-ui/surface#770 ·
-
Website is down未关闭
难度 4/5 3-5 天 新手友好度 35/100
surface-ui/surface#768 · 4 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
surface-ui/surface#762 · 2 条评论 · 1 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 35/100
surface-ui/surface#759 · 1 个 reaction ·
查看 surface-ui/surface 的全部 Issue
相似的 Issue
-
documentation
难度 2/5 1-3 小时 新手友好度 62/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 2 天内回复
-
ci-cd
难度 2/5 1-3 小时 新手友好度 72/100
carverauto/serviceradar#5648 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
opentelemetry_bandit: handler is detached when a client disconnects before the request starts (get_peer_data raises :enotconn)可能已有人在做 @yordis 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
open-telemetry/opentelemetry-erlang-contrib#846 ·
维护者通常 1 天内回复