[BUG]: `math/base/special/gammainc` is off by up to 0.03 for x > 1000 when a is close to x

未关闭
#16,533 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@manit2004 已经在做这个了。

开始于 2026年11月7日。

  • #16534 来自 @manit2004 —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
javascript

调研方向

Read lib/node_modules/@stdlib/math/base/special/gammainc/lib/tgamma_i_large_x_series.js and the corresponding C implementation in src/main.c; the issue identifies the off-by-one initialization in both. Start by checking the four reproduction cases against the expected values, then inspect the existing tests for these implementations. Done when the JavaScript and C results match the expected values for large x with a near x, and related distribution results are corrected.

由索引模型根据 Issue 内容生成。

描述

Bug Math Numerical Accuracy
Description

Encountered an error when evaluating gammainc with x > 1000 and a near x. The large-x asymptotic series (tgamma_i_large_x_series.js) starts its falling factorial at a instead of a - 1, so results are off by up to a few percent. This propagates to stats/base/dists/poisson/cdf, chisquare/cdf, gamma/cdf and others for large parameters.

In lib/node_modules/@stdlib/math/base/special/gammainc/lib/tgamma_i_large_x_series.js, var a = a1; should be var a = a1 - 1.0;, matching Boost's incomplete_tgamma_large_x_series (a_poch(a - 1)). With that one-line change the four values below match SciPy. The C implementation in src/main.c (ac = a; at line 703, in the same series) has the same off-by-one.

Found with a differential-testing tool; the report was drafted with AI assistance and reviewed and edited by me.

Related Issues

None.

Questions

No.

Demo

https://trackoor.github.io/stdlib-gammainc-large-x-repro/ (source: https://github.com/trackoor/stdlib-gammainc-large-x-repro). It shows the first three values from the jsDelivr ESM build; the chisqCDF value is only wrong in the npm build.

Reproduction
var gammainc = require( '@stdlib/math-base-special-gammainc' );
var poissonCDF = require( '@stdlib/stats-base-dists-poisson-cdf' );
var chisqCDF = require( '@stdlib/stats-base-dists-chisquare-cdf' );

console.log( gammainc( 1367.3436948118986, 1409.203708740708 ) );
console.log( gammainc( 1001, 1000.5, true, true ) );
console.log( poissonCDF( 999, 1001 ) );
console.log( chisqCDF( 2500, 2400 ) );
Expected Results
0.13190499189857086
0.489491914600245
0.48318854707021375
0.9241270884571916

(SciPy 1.10.1: gammainc(1409.203708740708, 1367.3436948118986), gammaincc(1000.5, 1001), poisson.cdf(999, 1001), chi2.cdf(2500, 2400))

Actual Results
0.09952119051642438
0.501850998882592
0.49530155533410974
0.9231500432608719
Version

@stdlib/math-base-special-gammainc 0.3.1; same code on develop 734972c

Environments

Node.js

Browser Version

Chrome 152 for the demo page; the report itself uses Node.js.

Node.js / npm Version

v26.13.0

Platform

Linux

Checklist
  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.

Credit: https://ucsbplse.github.io/

主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 21 小时
30 天内合并 PR
224

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

stdlib-js/stdlib 的其他 Issue

查看 stdlib-js/stdlib 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。