Fix JavaScript lint errors

未关闭 适合新手
#14,759 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
76/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript
领域
ci-cd, tooling

调研方向

先从 lib/node_modules/@stdlib/array/base/zip2views/lib/main.js 和 lib/node_modules/@stdlib/utils/group/examples/index.js 开始,然后运行失败信息中显示的 JavaScript lint workflow 或 make 目标。修复这些文件中报告的五个 ESLint 错误,并确认 lint 运行无错误完成。

由索引模型根据 Issue 内容生成。

描述

Good First Issue

JavaScript Linting Failures

Linting failures were detected in the automated JavaScript lint workflow run.

Workflow Details
Error Details
make[1]: Entering directory '/home/runner/work/stdlib/stdlib'

Linting file: lib/node_modules/@stdlib/_tools/changelog/parse-commits/lib/conventional_changelog.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/slinspace/lib/native.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/gtriu2tril/lib/base.js

Linting file: lib/node_modules/@stdlib/repl/presentation/lib/style_line.js

Linting file: lib/node_modules/@stdlib/ndarray/base/every/lib/4d_complex.js

Linting file: lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/lib/native.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/gsort2ins/lib/index.js

Linting file: lib/node_modules/@stdlib/stats/base/dists/binomial/cdf/lib/index.js

Linting file: lib/node_modules/@stdlib/array/base/zip2views/lib/main.js

/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/array/base/zip2views/lib/main.js
114:2  error  Function 'Datum' should be moved to module scope     stdlib/no-unnecessary-nested-functions
143:2  error  Function 'getValue' should be moved to module scope  stdlib/no-unnecessary-nested-functions
165:2  error  Function 'setValue' should be moved to module scope  stdlib/no-unnecessary-nested-functions

✖ 3 problems (3 errors, 0 warnings)

Linting failed.

Linting file: lib/node_modules/@stdlib/random/base/gumbel/lib/index.js

Linting file: lib/node_modules/@stdlib/random/array/gamma/lib/main.js

Linting file: lib/node_modules/@stdlib/math/base/special/expf/scripts/evalpoly.js

Linting file: lib/node_modules/@stdlib/ndarray/base/count-truthy/lib/8d.js

Linting file: lib/node_modules/@stdlib/constants/float16/ninf/lib/index.js

Linting file: lib/node_modules/@stdlib/repl/lib/regexp_workspace.js

Linting file: lib/node_modules/@stdlib/plot/components/svg/symbols/lib/props/y-scale/set.js

Linting file: lib/node_modules/@stdlib/stats/base/dists/t/mode/lib/native.js

Linting file: lib/node_modules/@stdlib/stats/base/dists/pareto-type1/cdf/lib/factory.js

Linting file: lib/node_modules/@stdlib/ndarray/base/napi/dtype-string-to-dtype/lib/index.js

Linting file: lib/node_modules/@stdlib/random/cauchy/lib/index.js

Linting file: lib/node_modules/@stdlib/ndarray/base/binary/lib/nd.js

Linting file: lib/node_modules/@stdlib/_tools/github/create-repo/lib/request.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/zindex-of-truthy/lib/ndarray.native.js

Linting file: lib/node_modules/@stdlib/ndarray/base/any/lib/3d_blocked_accessors.js
make[1]: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/eslint.mk:261: eslint-files] Error 1
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib'
make: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/Makefile:158: lint-javascript-files] Error 2
make[1]: Entering directory '/home/runner/work/stdlib/stdlib'

Linting file: lib/node_modules/@stdlib/stats/base/ndarray/mskmidrange/examples/index.js

Linting file: lib/node_modules/@stdlib/math/strided/special/ahaversin-by/examples/index.js

Linting file: lib/node_modules/@stdlib/blas/base/gsyr/examples/index.js

Linting file: lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-no-duplicate-headings-in-section/examples/index.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/dapxsumors/examples/index.js

Linting file: lib/node_modules/@stdlib/stats/base/dists/levy/stdev/examples/index.js

Linting file: lib/node_modules/@stdlib/blas/base/zswap/examples/index.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/zone-to/examples/index.js

Linting file: lib/node_modules/@stdlib/stats/strided/dmeanlipw/examples/index.js

Linting file: lib/node_modules/@stdlib/utils/group/examples/index.js

/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/utils/group/examples/index.js
35:7  error  Using the `new Array()` constructor is not allowed; use an array literal with push instead  stdlib/no-new-array
42:5  error  Using the `new Array()` constructor is not allowed; use an array literal with push instead  stdlib/no-new-array

✖ 2 problems (2 errors, 0 warnings)

Linting failed.

Linting file: lib/node_modules/@stdlib/array/datespace/examples/index.js
make[1]: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/eslint.mk:261: eslint-files] Error 1
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib'
make: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/Makefile:158: lint-javascript-files] Error 2
Pull Request Instructions
  • Please use the following PR title format:
    "chore: fix JavaScript lint errors (issue #<ISSUE_NUMBER>)".
  • Reference this issue in the "Related Issues" section of the PR body as "resolves #<ISSUE_NUMBER>".
主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 1 小时
30 天内合并 PR
559

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

stdlib-js/stdlib 的其他 Issue

查看 stdlib-js/stdlib 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。