Warning dialog not displayed after updating site handle
维护者通常 1 天内回复
已经有一个关联 PR 被合并了。
- #15722 来自 @lazerg —— 已合并
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- javascript, php
调研方向
Start with resources/js/pages/sites/Edit.vue, linked in the issue, and inspect how initialSiteHandles and currentSiteHandles are initialized and compared. Reproduce the steps at /cp/sites by changing a handle and saving; done means the warning dialog appears and the change is saved only after confirmation. A linked open pull request (#15722) indicates work is already underway.
由索引模型根据 Issue 内容生成。
描述
Bug description
In site configuration page, updating a site handle and clicking Save shows a success toast message immediately.
A warning confirmation dialog is included in the codebase but is never displayed. As a result, users don't get to see the warning dialog with its message: Warning! Changing a site handle may break existing site content!'.
Possible cause:
In Edit.vue (resources/js/pages/sites), the computed property initialHandleChanged always returns false. It seems currentSiteHandles holds a reference to the same array as initialSiteHandles, not a copy, so updating one updates the other.
Expected result:
A confirmation dialog with its warning message appears. The change is saved only after the user confirms.
Actual result:
No dialog appears. The change is saved immediately, and a success toast is shown.
How to reproduce
https://github.com/user-attachments/assets/56b94ba7-c24a-4dbc-86b3-f9c7fc8d070a
- Go to /cp/sites.
- Change the
Handlefield value of a site (for example, default → main). - Click Save.
Logs
Environment
Environment
Laravel Version: 12.69.2
PHP Version: 8.3.10
Composer Version: 2.10.2
Environment: local
Debug Mode: ENABLED
Maintenance Mode: OFF
Timezone: UTC
Locale: en
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: log
Cache: file
Database: sqlite
Logs: stack / single
Mail: log
Queue: sync
Session: file
Storage
public/storage: NOT LINKED
Statamic
Addons: 0
License Key: Not set
Sites: 1
Stache Watcher: Enabled (auto)
Static Caching: Disabled
Version: 5.70.0 PRO
Installation
Fresh statamic/statamic site via CLI
Additional details
No response
- 主要语言
- PHP
- 星标
- 4.9k
- 派生
- 647
- 平均合并
- 1 天 10 小时
- 30 天内合并 PR
- 143
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
statamic/cms 的其他 Issue
-
multisite ui
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
accessibility
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
[7.x] Reintroduce parser error for mixed pipe/shorthand modifier syntax可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭antlers
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
caching nocache
难度 3/5 1-2 天 新手友好度 42/100
维护者通常 1 天内回复
相似的 Issue
-
L: javascript
难度 2/5 1-3 小时 新手友好度 72/100
dependabot/dependabot-core#16744 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 78/100
linuxserver/docker-bookstack#302 · 1 条评论 ·
-
难度 2/5 1 小时以内 新手友好度 62/100
OpenConext/OpenConext-devconf#101 ·
-
component/document-portal domain/b2b
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复