Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Solid 2: reconcile repeats unchanged presence and holds unrelated updates

已关闭
  • 哪里不对？
#3,743 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript
领域
frontend

调研方向

Start with packages/signals/src/store/next/store.ts, especially notifyFold and notifyFoldTail, then run the linked playground reproduction. Add an isolated regression test for the unchanged-absence case and verify that Value: 1 renders while the deletion action remains pending, while actual presence changes still notify.

由索引模型根据 Issue 内容生成。

描述

Describe the bug

Reconciling a plain store can hold an unrelated field's rendered update behind a pending action when a separate in expression observes a property that the action deleted. The incoming snapshot leaves that property absent, matching its already-staged presence.

Reproduction

One-button playground — preview 3ed3810, Tailwind disabled.

Click Build, then Run reproduction. The sequence is:

// Initial store: { a: { value: 0 }, b: { failed: true } }
const removeFlag = action(function* () {
  setState(draft => { delete draft.b.failed; });
  yield gate;
});

// In a later event, while removeFlag is pending:
setState(reconcile({ a: { value: 1 }, b: {} }));

The component separately renders state.a.value and "failed" in state.b; no memo combines them. The playground releases the action after 2.5 seconds.

Expected: Value: 1 appears while the deletion action remains pending.

Actual: Value: 0 remains until that action finishes, then becomes 1.

Controls and investigation

Verified in Chromium and Firefox, in development and production builds:

  • Removing the separate presence expression allows the value to update immediately.
  • Assigning failed = false instead of deleting it, and reconciling the same false, allows it to update immediately.
  • Writing a.value = 1 directly instead of reconciling allows it to update immediately.

The suspected cause is the presence notification in notifyFold and notifyFoldTail. Value notifications compare old/new values, but the presence loops call setSignal for every observed key without comparing presence. The core joins the node's holding transaction before rejecting an equal value, so repeating false can entangle the reconciliation with the deletion action.

Adding an old/new presence comparison to both loops in an isolated test bundle prevents the hold. This is diagnostic evidence, not a fully validated patch.

Actual presence changes must still notify: deleting a prop override can select another merge source even when the resulting value is equal. This reproduction has no merge or provider switch; the suspected problem is the repeated absence-to-absence notification.

Version

solid-js and @solidjs/web from https://pkg.pr.new/mizulu/solid2/...@3ed3810 (Solid commit 3ed3810097bfc5e5d15829277b40315bbd2b5f74).

主要语言
TypeScript
星标
36.2k
派生
1.1k
平均合并
11 小时 19 分钟
30 天内合并 PR
337

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

solidjs/solid 的其他 Issue

查看 solidjs/solid 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。