Link click handling breaks the <Router> isolation/context principle
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- typescript
调研方向
在链接的 CodeSandbox 中使用两个 Router 实例重现该问题,然后检查 A 组件的文档级点击处理以及 Router 上下文/集成路径。确认每个 Router 下的点击都会调用该 Router 的集成 setter,并根据列出的复现步骤验证行为。
由索引模型根据 Issue 内容生成。
描述
Describe the bug
I'm making the assumption here that this package supports multiple routers running at the same time as it does use context for isolation instead of some kind of global store. Described bug is not an issue if my assumption is wrong.
Router component provides context which isolates and enforces the scope of router functionality.
For example useLocation under <Router> returns the location for that particular router.
Link click handling (A component) breaks that principle and functionality because link click event handler is added to document and if you have multiple routers (with default integration or custom), only one integration setter will be always called.
I propose to handle it in some sort of scoped way, for example:
<Router scopeEl={htmlElementRef} source={integration}> and
const target = args.scopeEl || document;
target .addEventListener("click", handleAnchorClick);
Or a bit more advanced (and potentially buggy): automatically find the nearest parent HTML element for <Router>.
Your Example Website or App
https://codesandbox.io/s/solid-app-router-example-forked-25ysls?file=/Index.js
Steps to Reproduce the Bug or Issue
- Go to Home (
/) if not already there and open console - Click on any of the "Post X (modal)" links
- Clear console log
- Click on any of the "Post X (modal)" links in modal (links under router 2)
You can see in logs [router 1] set global loc: that even though this link is rendered under second <Router>, it will still invoke the setter for first <Router> integration.
Expected behavior
Link behaviour respects the context.
Link rendered under <Router1 source={integration1}> should invoke the integration1 setter.
Link rendered under <Router2 source={integration2}> should invoke the integration2 setter.
Screenshots or Videos
No response
Platform
- OS: any
- Browser: any
- Version: 0.8.3
Additional context
No response
- 主要语言
- TypeScript
- 星标
- 1.3k
- 派生
- 180
- 平均合并
- 1 天 10 小时
- 30 天内合并 PR
- 19
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
solidjs/solid-router 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
solidjs/solid-router#605 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 65/100
solidjs/solid-router#615 ·
-
难度 3/5 1-2 天 新手友好度 78/100
solidjs/solid-router#603 · 1 条评论 ·
-
<A> costs ~6us of server CPU per instance during SSR (20x a plain <a>), mostly mergeProps/splitProps 未关闭
难度 4/5 3-5 天 新手友好度 55/100
solidjs/solid-router#583 ·
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
solidjs/solid-router#569 · 3 条评论 ·
查看 solidjs/solid-router 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
bcgov/bc-wallet-mobile#4761 · 1 条评论 ·
-
external-issue to-triage
难度 2/5 1-3 小时 新手友好度 88/100
-
area-deployment area-integrations triage:bot-seen
难度 2/5 半天 新手友好度 86/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
refactor
难度 2/5 1-3 小时 新手友好度 84/100