[Web] GestureDetector blocks context menu by default
维护者通常 2 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 56/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- react-native, typescript
调研方向
Start in web/handlers/GestureHandler.ts and v3/detectors/HostGestureDetector.web.tsx, where the issue identifies the context menu defaults and reset path. Compare those paths with GestureHandlerWebDelegate.shouldDisableContextMenu and the v2 behavior described here. Add or update web tests for native context menus and onContextMenu propagation; done means the native menu is suppressed only for an explicit false setting or a gesture using MouseButton.RIGHT.
由索引模型根据 Issue 内容生成。
描述
Description
Since v3, every gesture handler on web blocks the browser's native context menu by default. Right-clicking anywhere inside a GestureDetector or an RNGH component (ScrollView, FlatList, Pressable, …) no longer opens the browser menu, even when the gesture doesn't use the right mouse button.
This worked in v2 (tested with 2.25.0). There, the native menu was only suppressed for gestures listening to MouseButton.RIGHT or with an explicit enableContextMenu={false}.
Why this is a problem
In a real app, whole screens will be wrapped in RNGH components (ScrollView, FlatList). contextmenu bubbles, and one preventDefault() on any ancestor cancels the browser menu. So a single default-configured handler anywhere above an element is enough to block it.
To use the native context menu or onContextMenu in an RNGH app, I now have to add enableContextMenu to every RNGH component that may contain an element with a context menu. That means nearly every GestureDetector, ScrollView and list in the app, plus third-party libraries built on RNGH that may not expose the prop. Missing one ancestor breaks it again.
enableContextMenu={true} is also not equivalent to the v2 default. It attaches a listener that calls e.stopPropagation(), so the event never reaches ancestors, including React's root listener, and onContextMenu handlers higher in the tree stop firing. In v2 the default (undefined) attached no listener at all, so both the native menu and onContextMenu worked without any extra props.
Root cause
GestureHandlerWebDelegate still uses the v2 check:
private shouldDisableContextMenu() {
return (
(this.gestureHandler.enableContextMenu === undefined &&
this.gestureHandler.isButtonInConfig(MouseButton.RIGHT)) ||
this.gestureHandler.enableContextMenu === false
);
}
In v3, enableContextMenu can no longer be undefined, so the first branch is dead and the second always matches:
web/handlers/GestureHandler.ts:private _enableContextMenu: boolean = false. It is only overwritten when the config value is notundefined, and the reset path sets it back tofalse.v3/detectors/HostGestureDetector.web.tsx→unpackDOMProps:source.enableContextMenu ?? DEFAULT_ENABLE_CONTEXT_MENU, whereDEFAULT_ENABLE_CONTEXT_MENU = false.
Expected
Same as v2: only suppress the native menu when enableContextMenu={false} is passed explicitly or the gesture listens to MouseButton.RIGHT.
Steps to reproduce
-
Render on web:
import { GestureHandlerRootView, ScrollView } from 'react-native-gesture-handler'; import { Text } from 'react-native'; export default function App() { return ( <GestureHandlerRootView style={{ flex: 1 }}> <ScrollView> <Text onContextMenu={() => console.log('onContextMenu')}> Right-click me </Text> </ScrollView> </GestureHandlerRootView> ); } -
Right-click the text.
-
With 3.4.0: no browser context menu appears.
-
Switch to 2.25.0 and repeat: the browser context menu opens.
A link to a Gist, an Expo Snack or a link to a repository based on this template that reproduces the bug.
Gesture Handler version
3.5.0
React Native version
0.86.0
Platforms
Web
JavaScript runtime
None
Workflow
None
Build type
None
Device
None
Device model
No response
Acknowledgements
Yes
- 主要语言
- TypeScript
- 星标
- 6.8k
- 派生
- 1.1k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 46
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
software-mansion/react-native-gesture-handler 的其他 Issue
-
[Jest][3.5.0] `fireEvent.press` no longer reaches `Touchable` when its child is inside an `InterceptingGestureDetector`可能已有人在做 @m-bert 于 3 天前认领。 未关闭Missing info Platform: Web
难度 3/5 1-2 天 新手友好度 72/100
software-mansion/react-native-gesture-handler#4689 · 4 条评论 ·
维护者通常 2 天内回复
-
[Android] v3 `ReanimatedSwipeable` takes over a vertical scroll in a React Native list once the finger drifts 10 dp sideways可能重新可做 @JaydeepAgravat 于 10 天前认领,目前没有进行中的 PR。 未关闭Platform: Android
难度 4/5 3-5 天 新手友好度 55/100
software-mansion/react-native-gesture-handler#4670 · 6 条评论 ·
维护者通常 2 天内回复
-
Jest: with the hook API, raw touch events fired under a `GestureDetector` don't reach ancestors under Testing Library 14可能重新可做 @aliassar 于 13 天前认领,目前没有进行中的 PR。 未关闭Platform: Android Platform: iOS
难度 3/5 1-2 天 新手友好度 66/100
software-mansion/react-native-gesture-handler#4656 · 1 条评论 ·
维护者通常 2 天内回复
-
[Android] A held tap on a Touchable or Pressable in ScrollView does nothing while the keyboard is up可能已有人在做 @m-bert 于 6 天前认领。 未关闭Missing repro Platform: Android
难度 4/5 3-5 天 新手友好度 50/100
software-mansion/react-native-gesture-handler#4653 · 7 条评论 ·
维护者通常 2 天内回复
-
[IOS] The "hitslop" attribute used in the packaging component FlatList does not work as expected.未关闭Close when stale Missing repro Platform: iOS
难度 3/5 1-2 天 新手友好度 48/100
software-mansion/react-native-gesture-handler#4649 · 2 条评论 ·
维护者通常 2 天内回复
查看 software-mansion/react-native-gesture-handler 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 83/100
pollen-robotics/reachy-mini-desktop-app#341 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 77/100
mike-north/AgentMonitors#648 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
vercel-labs/ui#700 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 2 天内回复