Heartbeat timeout is no longer reset on packet

未关闭
  • 哪里不对？
#5,450 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

  • #5523 来自 @GiHoon1123 —— 已关闭，未合并
  • #5524 来自 @GiHoon1123 —— 已关闭，未合并

评估

难度
3/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
node.js, typescript
领域
backend-api-design, networking

调研方向

首先跟踪 Socket.IO 服务器的 heartbeat timeout 处理，并将其与所引用的 engine.io 修复以及后续的 revert 进行比较。通过发送大量客户端数据包来复现该问题，然后验证当数据包持续到达时连接仍保持存活，而不是在 ping interval 和 timeout 之后断开连接。

由索引模型根据 Issue 内容生成。

描述

needs investigation

Describe the bug
We have a high volume of data incoming from our sockets and they get disconnected at PingInterval+Timeout s with a ping timeout because the server has not received a pong, however it has received other messages from these sockets.

Image

Note how some connections drop after ~40seconds and reconnect.

There was a fix for this in https://github.com/socketio/engine.io/commit/be7b4e7478132a9409603327b27d1aa1970dd1d9 which got reverted in https://github.com/socketio/socket.io/commit/5359bae683e2a25742bd4989d0355a8fc10d294e

While I understand the "wastefulness" of creating timers on every packet, I still think the point of the socket being very much alive if there is data coming from it is valid (even when the pong packages is coming through timely).

Is there a chance to revert the revert?

To Reproduce

Please fill the following code example:

Socket.IO server version: 4.x

Send a lot of packages from the client, watch them disconnect after ~40 seconds even when data is coming from them.

Expected behavior
Connections should not be considered stale if there are still packets coming.

主要语言
TypeScript
星标
63.2k
派生
10.2k
平均合并
6 天 4 小时
30 天内合并 PR
6

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

socketio/socket.io 的其他 Issue

查看 socketio/socket.io 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。