F1: fertility-rate predictor inconcistency between estimation and Java implementation
@dariaple 已经在做这个了。
开始于 2026年10月23日。
评估
这个 Issue 还没有评估数据。
描述
The UK F1 equation is estimated using a national annual fertility-rate series, but Java evaluates the coefficient using a regional measure derived from population projections. This mismatch remains in develop at commit 971d050, checked on 23 October 2026.
Estimation
The UID construction assigns dukfr by calendar year only, with the label "UK General fertility rate (ONS)": 02_create_UKHLS_variables.do, lines 1846–1867.
The regression preparation then sets fertilityRate = dukfr (variable_update.do, lines 679–680), and the active F1 probit includes fertilityRate. Thus all observations in the same year receive the same national rate, irrespective of region.
Java implementation
For ordinary simulated persons, the FertilityRate getter instead calls getFertilityRateByRegionYear(getRegion(), getYear()). The lower-case fertilityRate getter delegates to it (lines 4016–4018).
Parameters.java, lines 1932–1960 constructs this as the projected number of children aged zero in the region divided by the projected number of women between the maternity-age limits, currently 18–49 (constants). The getter multiplies this by 1,000.
The coefficient is therefore applied to a different predictor from the one used in estimation: both the geographical variation and the construction differ. This is not a missing per-1,000 conversion, and switching fertility alignment on or off does not make the two predictor definitions consistent. The size of the effect on validation results needs to be assessed after the intended definition is agreed.
Question and proposed resolution
Should F1 be re-estimated using a consistently defined regional fertility-rate series, as suggested in the meeting, or should Java instead use a national predictor consistent with estimation?
Would it make sense to agree on a common definition for estimation and simulation, including the geographical coverage, age range and timing? If this involves changing the predictor used in estimation, I imagine we would also need to re-estimate F1. I would be happy to help check the resulting consistency between Stata and Java.
- 主要语言
- Java
- 星标
- 26
- 派生
- 38
- 平均合并
- 13 小时 5 分钟
- 30 天内合并 PR
- 7
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
simpaths/SimPaths 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 89/100
-
bug
难度 1/5 1 小时以内 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 62/100
-
难度 4/5 3-5 天 新手友好度 45/100
-
H2: should dlltsd01 be set to zero for retirees?可能已有人在做 @Kolndre 于 5 天前认领。 未关闭
查看 simpaths/SimPaths 的全部 Issue
相似的 Issue
-
Bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
protobuf
难度 2/5 1-3 小时 新手友好度 84/100
FasterXML/jackson-dataformats-binary#874 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 75/100
-
Add the AI-disclosure footer to README.md可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
-
Add the AI-disclosure footer to README.md可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
HexaHexes/infinite-dungeon-spawn-safety#17 ·
维护者通常 1 天内回复