add_ranges_file appends a second header reference when the companion spells the range id in another normalization
还没有人认领这个 Issue。
评估
调研方向
从 src/sil_lift/_model.py:825-829 中的 add_ranges_file 开始，将其引用查找与 src/sil_lift/_validate.py:432 中的 NFC 解析闭包进行比较。为 NFC/NFD 范围 ID 添加一个手写的回归用例，保留现有 header 的拼写，同时避免重复引用。完成的标准是 save() 写入一条引用，且验证行为保持不变。
由索引模型根据 Issue 内容生成。
描述
Summary
Lexicon.add_ranges_file decides which ranges the header already references by exact string
comparison, so a header that spells a range id in NFC and a companion that spells it in NFD
are treated as unrelated ranges: a second <range> header reference is appended for the
same conceptual range, and save() writes both. FLEx mixes normalizations between an id and
the references to it (#14, #27), so a lexicon derived from a real export is exactly where
the two spellings meet.
Reproduction
import sil_lift, unicodedata
nfd = lambda s: unicodedata.normalize("NFD", s)
name = "Catégorie"
lex = sil_lift.Lexicon()
lex.header.ranges.append(sil_lift.Range(id=name, href="dup.lift-ranges")) # NFC in the header
ranges = sil_lift.RangesFile()
ranges.add_range(nfd(name)).add_element("Nom") # NFD in the companion
lex.add_ranges_file(ranges, href="dup.lift-ranges")
print([ascii(r.id) for r in lex.header.ranges])
lex.save("dup.lift")
["'Cat\\xe9gorie'", "'Cate\\u0301gorie'"]
and in the saved .lift:
<ranges>
<range id="Catégorie" href="dup.lift-ranges"/>
<range id="Catégorie" href="dup.lift-ranges"/>
</ranges>
Two references, rendering identically, differing only by normalization — one of which the
caller never asked for.
Cause
src/sil_lift/_model.py:825-829:
referenced = {range_.id for range_ in self.header.ranges}
for range_ in ranges_file.ranges:
if range_.id not in referenced:
self.header.ranges.append(Range(id=range_.id, href=href))
referenced.add(range_.id)
The membership test is exact, so the two spellings of one name are different keys.
Expected
Resolve referenced the way the validator resolves a name to an id — exact spelling first,
then NFC — and append nothing when the header already references the range under either
spelling. The existing header id must not be rewritten: whichever spelling the document came
with is the one it keeps.
Scope
Write path only. Validation of such a document is already correct as of #28, which resolves
a header range/@id against a companion's range id under NFC and reports the split as a
normalization-mismatch warning. This is about what save() then writes.
Distinct from #29: that is the merged read view (all_ranges()) dropping a range when two
companions define the same id. Same underlying theme — ids compared as exact strings — but a
different code path and a different symptom. See also the all_ranges() NFC-keying note on
that issue.
Notes
Pre-existing; not introduced by #28.
Reachability is narrow: it needs a header that already references the range under one
spelling plus a call to add_ranges_file with a companion spelling it the other way — the
documented "call again to reference ranges added later" flow on a FLEx-derived lexicon. No
corpus fixture exercises it, so this needs a hand-authored case.
One design decision comes with it: the package's only NFC machinery is three closures inside
_semantic_problems (src/sil_lift/_validate.py:432). Fixing this needs either a second
unicodedata.normalize call in _model.py or promoting nfc/resolve into a shared
private module. The latter is probably right if any other module ever needs it, but it is
worth deciding deliberately rather than inlining a call a later refactor has to undo.
- 主要语言
- Python
- 星标
- 1
- 派生
- 0
- 平均合并
- 9 天 17 小时
- 30 天内合并 PR
- 4
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
sillsdev/python-sil-lift 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 84/100
sillsdev/python-sil-lift#15 ·
-
bug
难度 5/5 一周以上 新手友好度 35/100
sillsdev/python-sil-lift#45 ·
-
bug
难度 3/5 1-2 天 新手友好度 72/100
sillsdev/python-sil-lift#35 ·
-
Evaluate full API surface for anything unnecessary可能已有人在做 @imnasnainaec 于 25 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 25/100
sillsdev/python-sil-lift#30 · 1 条评论 · 已指派 1 人 ·
-
bug
难度 4/5 3-5 天 新手友好度 45/100
sillsdev/python-sil-lift#29 · 1 条评论 ·
查看 sillsdev/python-sil-lift 的全部 Issue
相似的 Issue
-
wr.dynamodb.read_items returns [{}] for a single partition value that does not exist可能已有人在做 @auraseb 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 84/100
aws/aws-sdk-pandas#3520 ·
维护者通常 2 天内回复
-
requires triage typing
难度 2/5 1-3 小时 新手友好度 78/100
sqlalchemy/sqlalchemy#13704 ·
维护者通常 1 天内回复
-
Edit tool converts CRLF files to LF可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
huggingface/tau#774 ·
维护者通常 1 天内回复
-
show ignores the row limit when a column or table name contains "limit"可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
linebender/resvg#1179 · 1 条评论 ·
维护者通常 2 天内回复