`url()`s containing file paths are not distinguishable from other arbitrary `Word` nodes
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- css, typescript
调研方向
Start by reproducing the documented postcss-values-parser examples for absolute and relative paths, then inspect how Word, Func, and isUrl are assigned during parsing. Compare the result with css-tree's Url nodes and the Word.md URL-handling documentation; done means relative url(/images/image.png) is distinguishable from arbitrary Word values in the parser output.
由索引模型根据 Issue 内容生成。
描述
Expected Behavior / Situation
It is common in CSS to specify URLs as an absolute or relative path without a scheme, e.g. url(/images/image.png). css-tree parses these as unambiguous Url nodes:
> const csstree = await import("css-tree")
> csstree.parse("url(https://example.com/image.png)", { context: "value" }).children.head.data
{ type: 'Url', loc: null, value: 'https://example.com/image.png' }
> csstree.parse("url(/images/image.png)", { context: "value" }).children.head.data
{ type: 'Url', loc: null, value: '/images/image.png' }
It was my expectation that postcss-values-parser would yield Func nodes for both of these inputs, per this documentation.
Actual Behavior / Situation
In reality, postcss-values-parser yields Word nodes in both cases:
> const valuesParser = (await import("postcss-values-parser")).parse
> valuesParser.parse("url(https://example.com/image.png)").nodes[0]
<ref *1> Word {
raws: {},
value: 'https://example.com/image.png',
source: [Object],
isColor: false,
isHex: false,
isUrl: true,
isVariable: false,
type: 'word',
parent: [Root],
Symbol(isClean): false,
Symbol(my): true
}
> valuesParser("url(/images/image.png)").nodes[0]
<ref *1> Word {
raws: {},
value: '/images/image.png',
source: [Object],
isColor: false,
isHex: false,
isUrl: false,
isVariable: false,
type: 'word',
parent: [Root],
Symbol(isClean): false,
Symbol(my): true
}
In the first case, isUrl is set as expected, but in the second case, since the value is not actually a valid URL (at least according to is-url-superb, which just uses new URL()—TBH just using URL.parse() or URL.canParse() directly without the dependency would make more sense iff requiring a minimum of Node 18 is possible, IMHO), it remains false and the node is not distinguishable from other non-URL values despite being unambiguous in the css-tree parse.
Modification Proposal
I suggest that the parser should behave according to the documentation, which would result in a parse something like this (hypothetical, not real output):
> valuesParser("url(/images/image.png)").nodes[0]
<ref *1> Func {
raws {},
value: '',
nodes: [
Word {
raws: {},
value: '/images/image.png',
source: [Object],
isColor: false,
isHex: false,
isUrl: false,
isVariable: false,
type: 'word',
parent: [Circular *1],
Symbol(isClean): false,
Symbol(my): true
}
],
source: [Object],
isColor: false,
isVar: false,
name: 'url',
params: '',
type: 'func',
parent: [Root],
Symbol(isClean): false,
Symbol(my): true
}
Or, failing that, set isUrl to true for Word nodes created from css-tree Url nodes regardless of whether the contents look like a URL.
[!NOTE]
My use case is similar to that of rollup-plugin-styler's URL loader, which parses URL and partial URL values in order to perform lookup resolution for bundling.
- 主要语言
- TypeScript
- 星标
- 62
- 派生
- 32
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
相似的 Issue
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
-
Crush 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
catppuccin/catppuccin#3125 ·
-
难度 1/5 1 小时以内 新手友好度 90/100
ElementsProject/cln-application#167 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 75/100
Quantco/pnpm-licenses#17 ·
-
难度 2/5 1-3 小时 新手友好度 75/100