chore(test): prove the short-lock scenario through a tool call
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- go
- 领域
- testing-qa
调研方向
Start with the existing tests in internal/graphstore/open_lock_test.go and internal/mcp/held_store_test.go, then read openLockRetrySleep in internal/graphstore/pebble_store.go and setRetrySleep in internal/graphstore/retry_test.go. The main work is exporting the retry seam through a graphstore subpackage such as locktest. Done means a new internal/mcp test holds the lock with locktest.HoldStoreLock, releases it during a codegraph_explore call, and asserts IsError is false and the text contains Alpha, with no timers.
由索引模型根据 Issue 内容生成。
描述
What kind of chore?
Test infrastructure.
What needs doing?
The spec scenario "A short lock" is in openspec/specs/mcp-server/spec.md. It belongs to the requirement "A briefly locked store does not fail or hang a call."
That scenario is proven only at the graphstore.Open level. No test shows a tool call that returns a result without isError after the lock is released during the retry.
Existing coverage:
TestOpenConvergesWhenHolderClosesininternal/graphstore/open_lock_test.go:26covers a release between two retry attempts.TestToolCallOnHeldStoreininternal/mcp/held_store_test.go:38covers a long lock and expectsisError.TestToolCallWhileProcessHasStoreOpenininternal/mcp/held_store_test.go:15does not hold a foreign lock.
Add a test in internal/mcp that holds the store lock with locktest.HoldStoreLock. The test must release the lock during a codegraph_explore call, then assert that IsError is false and that the text contains Alpha.
The blocker is the retry seam. openLockRetrySleep (internal/graphstore/pebble_store.go:106) is unexported, and setRetrySleep (internal/graphstore/retry_test.go:17) works only inside package graphstore. Package mcp cannot release the lock from inside the retry.
Expose the seam to other packages through an exported test helper in a graphstore subpackage such as locktest. The test must not use a timer, because the house rule forbids sleeps and wall-clock waits in tests.
Source: review note tes-1 in openspec/changes/archive/2026-11-11-shared-store-handle/review.md:33, from PR #282.
Why now?
PR #282 added the shared store handle that this scenario depends on. The review of that PR flagged this gap as tes-1. Without the test, a regression in how a tool call handles a briefly held lock can pass the suite.
Does this touch anything load-bearing?
- None of these
Before submitting
- I searched existing issues and this is not a duplicate
- 主要语言
- Go
- 星标
- 0
- 派生
- 0
- 平均合并
- 7 小时 42 分钟
- 30 天内合并 PR
- 111
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
seanb4t/codegraph-go 的其他 Issue
-
chore needs-triage
难度 1/5 1 小时以内 新手友好度 88/100
seanb4t/codegraph-go#380 ·
维护者通常 1 天内回复
-
chore needs-triage
难度 2/5 1-3 小时 新手友好度 82/100
seanb4t/codegraph-go#379 ·
维护者通常 1 天内回复
-
area:query chore needs-triage spec-needed
难度 2/5 1-3 小时 新手友好度 74/100
seanb4t/codegraph-go#377 ·
维护者通常 1 天内回复
-
chore needs-triage
难度 1/5 1-3 小时 新手友好度 84/100
seanb4t/codegraph-go#362 ·
维护者通常 1 天内回复
-
area:query bug needs-triage
难度 2/5 1-3 小时 新手友好度 80/100
seanb4t/codegraph-go#355 ·
维护者通常 1 天内回复
查看 seanb4t/codegraph-go 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
automated documentation maintenance
难度 1/5 1-3 小时 新手友好度 75/100
github/gh-aw-mcpg#16717 ·
维护者通常 1 天内回复
-
Docs: Recording rules pages don't say what happens to a recorded metric when its rule is deleted未关闭internal
难度 1/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 74/100
jesseduffield/lazygit#6229 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
prometheus/prometheus#20482 ·
维护者通常 2 天内回复