Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

`rc mirror` Upload Performance

未关闭
  • 哪里不对？
#385 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
78/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
cli, performance

调研方向

Start in crates/s3/src/client.rs around lines 4300-4312, then inspect the single-part and multipart upload paths and their handling of ObjectWritePrecondition. Use the reported nested-folder benchmark as the validation baseline. Done means small preconditioned files avoid unnecessary multipart requests while If-None-Match and If-Match behavior remains correct.

由索引模型根据 Issue 内容生成。

描述

I recently compared the upload performance of rc mirror vs MinIO's mc mirror against a RustFS server.

Generally, rc mirror turned out to be about six times slower than mc mirror on my machine. I did some investigation and found two major causes for this:

  1. mc mirror seems to use stronger parallelization per default
  2. Small files get uploaded by mc mirror as single PutObject operations, whereas rc mirror always uses a multipart upload.

Point 2 means that for small files, rc mirror makes three requests instead of one, and accordingly triples the upload time. In the code (crates/s3/src/client.rs line 4300-4312, I found a reason for that, namely

// RustFS evaluates write preconditions for multipart completion. Keep
// ordinary small uploads on PutObject, but route conditional path writes
// through multipart so mirror retains compare-and-swap semantics on the
// currently deployed service.
if Self::should_use_multipart(file_size)
    || !matches!(precondition, ObjectWritePrecondition::None)
{
    self.put_object_multipart_from_path(path, file_path, file_size, options, on_progress)
        .await
} else {
    self.put_object_single_part_from_path(path, file_path, file_size, options)
        .await
}

So I understand that's a safeguard to ensure write preconditions are respected. However, since version 1.0.0-alpha.47 (rustfs/rustfs#409), RustFS also enforces If-None-Match/If-Match write preconditions on PutObject itself.
I would therefore suggest to drop the multipart upload route for small files with preconditions. I have already tested it (approx. 25k files in a nested folder structure, with average file size of ~25 KB), and it expectedly increases upload performance by roughly a factor of three for small files (still significantly slower than mc, though):

Command Number of runs Average real time Average user time Average sys time
mc mirror 10 25.120s 9.295s 9.815s
rc mirror 10 168.318s 12.236s 16.648s
rc mirror (skip multipart for small files) 10 42.561s 6.254s 9.561s

Are there any objections against this change? If not, I'd be happy to set up a PR.

主要语言
Rust
星标
159
派生
23
平均合并
7 小时 4 分钟
30 天内合并 PR
10

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

rustfs/cli 的其他 Issue

查看 rustfs/cli 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。