Upgrade datatables.net-dt from 1.13 to 3.x and check every table (#7248)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 67/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, jquery, rails
- 领域
- frontend
调研方向
Read the DataTables 2.0 and 3.0 upgrade notes, then inspect app/javascript/datatable.js, app/javascript/src/all_casa_admin/tables.js, app/javascript/src/emancipations.js, and their import in app/javascript/application.js. Run bin/dev with the README seed logins and check sorting, search, pagination, and styling on each table; rerun the named system spec on main to assess flakiness. Done means the upgrade works across the tables and the PR includes before-and-after screenshots.
由索引模型根据 Issue 内容生成。
描述
Problem
Dependabot's #7248 bumps datatables.net-dt from 1.13.11 to 3.1.4, skipping a whole major version (2.x). Its CI failed docker with one system spec:
rspec ./spec/system/volunteers/edit_spec.rb:155 # saves the user as inactive, but only if the admin confirms
Unable to find modal dialog
That spec may just be flaky, since it isn't obviously related to tables. But a jump across two majors needs a real check of every table in the app, not only green CI.
Where DataTables is used
app/javascript/datatable.js:$(selector).DataTable({ searching: true, order: [[0, 'asc']] })app/javascript/src/all_casa_admin/tables.js: admin and organization lists on the All CASA admin pagesapp/javascript/src/emancipations.js:table#all-case-emancipations- Imported from
app/javascript/application.js; styles come from the-dtpackage
Tasks
- Read the DataTables 2.0 and 3.0 upgrade notes. Check how the jQuery plugin is imported and initialised, and whether the options we pass changed.
- Check each table above in the browser (
bin/dev, seed logins in the README): sorting, search box, pagination, styling - Rerun the
volunteers/edit_spec.rb:155system spec onmaina few times. If it fails there too, it's flaky: file it per our flaky-test process instead of blocking this. - Open a PR with the bump plus any code changes, with before/after screenshots of each table
- Longer term (separate issue): the redesign is moving tables to Tailwind and Stimulus, so check whether these tables still need DataTables at all
Difficulty: intermediate.
- 主要语言
- Ruby
- 星标
- 382
- 派生
- 547
- 平均合并
- 2 天 22 小时
- 30 天内合并 PR
- 46
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
rubyforgood/casa 的其他 Issue
-
Remove leftover Cloud66 custom_web process from Procfile可能已有人在做 @ShahadatTest 于 1 天前认领。 未关闭Difficulty: Easy Good First Issue
难度 1/5 1 小时以内 新手友好度 88/100
rubyforgood/casa#7330 · 1 条评论 ·
维护者通常 1 天内回复
-
Remove the bin/bundle binstub (Heroku warns it can break Bundler on deploy)可能已有人在做 @KoushikSagarr 于 1 天前认领。 未关闭dependencies Difficulty: Easy Good First Issue
难度 1/5 1 小时以内 新手友好度 82/100
rubyforgood/casa#7325 · 1 条评论 ·
维护者通常 1 天内回复
-
Difficulty: Easy Good First Issue Help Wanted javascript
难度 2/5 1-3 小时 新手友好度 72/100
rubyforgood/casa#7311 ·
维护者通常 1 天内回复
-
Difficulty: Easy Good First Issue Help Wanted javascript
难度 2/5 1-3 小时 新手友好度 78/100
rubyforgood/casa#7310 ·
维护者通常 1 天内回复
-
Difficulty: Easy Good First Issue Help Wanted javascript
难度 2/5 1-3 小时 新手友好度 78/100
rubyforgood/casa#7309 ·
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
TheOdinProject/curriculum#31512 ·
维护者通常 1 天内回复
-
area/web interface
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
ruby-grape/grape-swagger#1014 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
rubys/roundhouse#1757 ·
-
难度 2/5 半天 新手友好度 72/100
shakacode/react-on-rails-demo-flagship#102 ·
维护者通常 1 天内回复