Question to seek clarification on the definition of "..." in type signatures
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
首先阅读 pull request #2540 和 issue #1293,然后将其中的讨论与本 issue 中的 Example1 和 Example2 签名进行比较。当明确解决 ... 表示继承的签名、重载还是两者兼有,以及该行为或其文档是否需要澄清时,即视为完成。
由索引模型根据 Issue 内容生成。
描述
Hi! I have a question regarding ..., specifically relating to https://github.com/ruby/rbs/pull/2540 / https://github.com/ruby/rbs/issues/1293
Prior to seeing this, I thought that:
...is used to denote overloaded method type signatures in the same class/module- Overriding a type signature from a class or module overwrites the parent signature, and it is no longer possible to reference it
After seeing this, I realise I possibly didn't understand ..., as it looks to me that:
...is also used to denote "defer to the parent type signature", similar to thesuperkeyword in Ruby...only denotessuperif there are no real method overloads
Take the following examples:
module Foo
def call: -> Integer
end
class Example1
include Foo
def call: -> Float | ...
end
class Example2
include Foo
def call: -> Float | ...
end
class Example2 # Overload/re-open
def call: -> Symbol
end
It looks to me (by RBS and Steep) that:
- Example1 uses
...to denote "super", and has type-> Integer | -> Float - Example2 uses
...to denote "overload", and has type-> Float | -> Symbol
I think that it would be great to hear what the intention of ... is, but I'll also just mention a couple of my thoughts on it:
- It feels problematic to me that a library may wish to use
...to denotesuper, but then thesuperfunctionality can be overridden if a user of the library adds an actual overload of the method signature. - Re-using
...to denotesupercould lead to confusion when reading type signatures - it is no longer clear whether this means the type signature is overloaded, or whether it is referring tosuper, especially if you have to know/understand if there are any re-openings of the class/module. - I think having a separate syntax for
supermay be better here for behaviour and readability
Thanks :)
- 主要语言
- Ruby
- 星标
- 2.2k
- 派生
- 263
- 平均合并
- 1 天 20 小时
- 30 天内合并 PR
- 64
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ruby/rbs 的其他 Issue
-
InlineParser: `@rbs @ivar` annotation is reported as unused unless it is the first thing in the class body可能已有人在做 @ksss 于 50 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 15/100
维护者通常 1 天内回复
相似的 Issue
-
bug f:request-creation professional
难度 2/5 1-3 小时 新手友好度 64/100
mysociety/alaveteli#9733 · 1 条评论 ·
维护者通常 1 天内回复
-
needs verification
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 13 天内回复
-
🐛 bug 👩💻 équipe CE 🧑🏭 entreprises
难度 2/5 1-3 小时 新手友好度 76/100
betagouv/conseillers-entreprises#4808 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
-
难度 2/5 1-3 小时 新手友好度 78/100