bundler and rubygems

未关闭
#2,599 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
技术栈
ruby
领域
tooling

调研方向

首先阅读 sig/shims/bundler.rbs 和 sig/shims/rubygems.rbs,然后将它们与 core 下的定义进行比较。明确 Bundler 签名是否应放在此仓库中,以及哪些公共 API 在范围内。当就附加 RBS 定义的放置位置和范围达成一致后,即视为完成。

由索引模型根据 Issue 内容生成。

描述

Hi!

Two questions:

First, I'd like folks to be able to typecheck their Gemfiles via Solargraph, which is able to use RBS for external types. The DSL for a Gemfile is described in Bundler::Dsl; having types described for that class is certainly a prerequisite.

Are you open to having types for bundler live in this project, presumably in core next to rubygems?

If not, Solargraph rbs collection, but it doesn't seem possible to add bundler via gem_rbs_collection, as rbs collection install only takes effect on gems.

Second, there are a number of public APIs in both bundler and rubygems that Solargraph uses in its own code that are not in the RBS repo. It appears you had the same issue, as I see shims for bundler and rubygems in your sig/shims directory.

Do you object to me adding these additional signatures to the definitions in https://github.com/ruby/rbs/tree/master/core? I was not sure if there was intent behind the decision to leave those as internal shims or if it was for expedience.

Much appreciation for your work on RBS! Solargraph is much more capable as a result, both as an LSP and a typechecker.

主要语言
Ruby
星标
2.2k
派生
263
平均合并
1 天 20 小时
30 天内合并 PR
64

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

ruby/rbs 的其他 Issue

查看 ruby/rbs 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。