Treat the WASM/WASI build target as cfg(unix) so filesystem tools need no per-tool mode-bit patches
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 冷清
- 技术栈
- rust, wasm
调研方向
从 uutils/coreutils' src/uucore/src/lib/features/fs.rs 开始,并将 registry/native/patches 下引用的 WASI 补丁与 which.rs 和 builtins 入口进行比较。调查此处描述的 target-spec、build-std 和 preview2 替代方案;完成的标准是选择并记录一个方向,以及它对兼容性和维护的影响。
由索引模型根据 Issue 内容生成。
描述
Summary
We build coreutils (ls, stat, chmod, …) for wasm32-wasip1. Because that
target is not cfg(unix), every crate's #[cfg(unix)] filesystem code —
the code that reads real st_mode permission bits — is compiled out, and the
#[cfg(not(unix))] fallback (which fabricates permissions from a single
readonly boolean) is compiled in. To get native-Linux-accurate output we've
had to hand-patch each tool to bypass that fallback and fetch mode bits from the
sidecar via a host_fs.path_mode import (landed in #268 / #269).
This issue tracks the larger question: should we make the WASM build target
present as cfg(unix) (a Linux-like target) so these tools "just work" with no
per-tool patches, instead of maintaining a growing pile of #[cfg(target_os = "wasi")] shims?
Why a non-Linux target breaks filesystem tools
uucore has two implementations of display_permissions, cfg-gated:
#[cfg(unix)] // reads REAL bits
pub fn display_permissions(md, ...) -> String {
display_permissions_unix(md.mode() as mode_t, ...) // st_mode
}
#[cfg(not(unix))] // WASI lands HERE — fabricates
pub fn display_permissions(md, display_file_type) -> String {
let write = if md.permissions().readonly() { '-' } else { 'w' };
format!("{file_type}r{write}xr{write}xr{write}x") // r & x HARDCODED on
}
Upstream root cause (uutils/coreutils, uucore 0.5.0):
https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/fs.rs
Consequences of being cfg(not(unix)):
md.mode()isn't even callable —std::os::unix::fs::MetadataExtdoesn't
exist in the WASIstd.- Rust's own
std::os::wasi::fs::MetadataExtdeliberately exposes
dev/ino/nlink/size/atim/…but nomode(), because WASI preview1's
filestatstruct has no mode field. So the bits are absent at thestdlayer
regardless of cfg. - Net effect:
ls -lprinted-rwxrwxrwx(or-r-xr-xr-xif readonly) for
every file — a uniform string derived from one boolean.
Note this is degradation, not deliberate stripping: the tools have "WASI
support," it's just a lossy fallback nobody wired to a host that has the bits.
Evidence: the per-tool workarounds this forces (all at 8145b07)
Each of these exists only because the target isn't cfg(unix):
ls— inject ahost_fs.path_modeimport +mode_for_pathand swap
display_permissions→display_permissions_unix:
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/patches/crates/uu_ls/0001-wasi-host-fs-mode-display.patch#L16-L74stat:
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/patches/crates/uu_stat/0001-wasi-metadata-compat.patchchmod:
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/patches/crates/uu_chmod/0001-wasi-compat.patch- First-party shims hit the same wall —
whichand the shell builtins each
carry their own#[cfg(target_os = "wasi")]host_fsextern:
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/crates/libs/shims/src/which.rs#L16-L58
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/crates/libs/builtins/src/lib.rs#L14-L27 - And the C side already has the mirror-image fix in wasi-libc (which Rust can't
reach, because Rust std bypasses libcstat()on wasip1):
https://github.com/rivet-dev/secure-exec/blob/8145b07ebcd1f6553a417a009091c53d7610a04f/registry/native/patches/wasi-libc/0016-host-fs-mode-and-chmod.patch
Every new fs-touching Rust tool we add will need another such patch.
Options
A. Force cfg(unix) on the current target (cheap, does NOT work)
Passing --cfg unix via RUSTFLAGS flips the cfg on our crates, but the
#[cfg(unix)] path does use std::os::unix::fs::MetadataExt, which the
precompiled WASI std doesn't contain → unresolved import. And even if it
resolved, the WASI Metadata's underlying filestat has no st_mode to
return. Rejected.
B. Custom Linux-like target spec + -Z build-std (the real "treat it like native")
Define a target derived from wasm32-wasip1 with target-family = ["unix", …]
and recompile std/core so Rust's fs routes through the libc-backed unix fs
backend (calls libc stat(), reads st_mode). Then the wasi-libc mode patch
(0016) flows up into Rust automatically and all #[cfg(unix)] tool code works —
no per-tool patches. Blast radius, however, is large:
- Nightly + build-std on every build; per-Rust-version maintenance of a bespoke
target. cfg(unix)flips the entire dep graph, not just perms — signals, process,
users/groups (getpwuid), termios, mmap, net — much of which calls libc
symbols WASI libc doesn't implement → link/ENOSYSbreakage to chase.- The fs backend (
target_os = "wasi") andMetadataExt(target_family = unix) are gated on different cfgs and don't cleanly compose; effectively a
std fork.
C. Move the runtime to WASI preview2 / wasi:filesystem (the clean long-term fix)
preview2 carries richer metadata than preview1's filestat. Migrating (or
upstreaming a wasi MetadataExt::mode() backed by an extended filestat) would
let these tools read real bits natively and let us delete all the patches —
without pretending to be unix.
Ask / decision needed
Decide between: (B) invest in a Linux-like custom target + build-std so fs tools
need zero patches, vs. (C) target preview2, vs. (status quo) keep adding small
per-tool host_fs patches. Leaning C long-term; B is the "make it native" ask
but has broad blast radius. Capturing so the tradeoff is explicit before the
patch pile grows.
Related PRs: #268 (filesystem native-parity: wasi-libc + sidecar host_fs),
#269 (coreutils stat/chmod/ls real permission bits).
- 主要语言
- TypeScript
- 星标
- 1k
- 派生
- 54
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
rivet-dev/dynamic-apps 的其他 Issue
-
Build cache ignores maxResponseBytes, potentially reusing an outdated response limit可能已有人在做 @Utkarshpandey0001 于 18 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 78/100
rivet-dev/dynamic-apps#297 ·
-
难度 3/5 1-2 天 新手友好度 58/100
rivet-dev/dynamic-apps#280 · 2 条评论 ·
-
Make agentOS runtime classifier content-based (match Linux exec semantics), not extension-based可能已有人在做 @mittal-parth 于 24 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 48/100
rivet-dev/dynamic-apps#275 ·
-
难度 4/5 3-5 天 新手友好度 55/100
rivet-dev/dynamic-apps#272 ·
-
难度 5/5 一周以上 新手友好度 42/100
rivet-dev/dynamic-apps#178 ·
查看 rivet-dev/dynamic-apps 的全部 Issue
相似的 Issue
-
[bug] diagnostics.dumpBody:Buffer 形态请求(透传 lane)跳过 dumps/ 落盘,仅留 raw/-unknown-可能已有人在做 @ranxianglei 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
ranxianglei/billion-context#2421 · 2 条评论 ·
维护者通常 1 天内回复
-
pending triage
难度 2/5 1-3 小时 新手友好度 76/100
nuxt/test-utils#1842 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
MoonshotAI/kimi-code#4146 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
farbenmeer/tapi#531 ·
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复