Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

[Android] RiveFonts: loadFont({name}) fails for script fonts on OEM fonts.xml; systemFallback() is not script-aware (tofu for Thai/Hebrew/Arabic/CJK)

未关闭
  • 哪里不对？
#369 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@mfazekas 已经在做这个了。

开始于 2026年10月3日。

  • #405 来自 @mfazekas —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
65/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
android, kotlin, react-native
领域
mobile-dev

调研方向

Start with FontFallbackStrategy.kt and HybridRiveFontConfig.applyFallbackFonts() and clearFallbackFonts(); trace how the style picker is stored and cleared. Confirm the fallback strategy remains available after asynchronous setup and that clearing it resets the cache, then verify setFallbackFonts() renders Thai, Hebrew, Arabic, and CJK text without tofu.

由索引模型根据 Issue 内容生成。

描述

android bug

UPDATE (root cause found): the primary bug is that the fallback strategy is garbage-collected. See "Root cause" below; the original report about name lookup is kept as a secondary issue.

Root cause: stylePicker is assigned into a WeakReference and immediately GC'd

rive-android stores the fallback strategy weakly (FontFallbackStrategy.kt):

// Use a WeakReference so these can be automatically cleaned up by the JVM.
private var stylePickerRef: WeakReference<FontFallbackStrategy>? = null

…but HybridRiveFontConfig.applyFallbackFonts() (both 0.4.10 and 0.4.19) assigns an anonymous object without retaining any strong reference to it:

override fun applyFallbackFonts(): Promise<Unit> {
  return Promise.async {
    FontFallbackStrategy.stylePicker = object : FontFallbackStrategy { ... } // ← nothing holds this
    ...
  }
}

The strategy becomes unreachable as soon as applyFallbackFonts returns, the next GC collects it, pickFont() starts returning emptyList(), and the engine falls back to the default system font — tofu for any non-Latin script. This explains why setFallbackFonts appears to succeed (JS promise resolves, fonts are loaded into byte arrays) while rendering still shows tofu, and why results look flaky (depends on GC timing).

Verified fix (we run this as a local patch)

Keep a strong reference alongside the weak assignment:

companion object {
  private var strongStylePicker: FontFallbackStrategy? = null
}

override fun applyFallbackFonts(): Promise<Unit> {
  return Promise.async {
    val picker = object : FontFallbackStrategy { ... }
    strongStylePicker = picker            // retain: rive-android holds only a WeakReference
    FontFallbackStrategy.stylePicker = picker
    resetFontCache()
  }
}

override fun clearFallbackFonts(): Promise<Unit> {
  return Promise.async {
    ...
    strongStylePicker = null
    FontFallbackStrategy.stylePicker = null
    resetFontCache()
  }
}

With this one-line retention, setFallbackFonts({ default: [loadedBytesFonts..., systemFallback()] }) works as documented on @rive-app/react-native 0.4.10 (rive-android 11.4.0): Thai/Hebrew/Arabic render correctly. Happy to send this as a PR.

App-side note for others hitting this

Because pickFont results are cached natively per weight, apply the new fonts before any text run is (re)shaped for the new locale — otherwise the tofu shaping result is cached until the strategy instance changes again.

Secondary issue (original report): font sourcing

1. loadFont({ name }) silently fails for script fonts on many devices — loadFontByName matches the name attribute of <family> entries in fonts.xml, but script families (Thai, Hebrew, Arabic, CJK, …) are typically declared without a name attribute (matched by lang). A lang-based lookup, or documented support for absolute font paths, would make sourcing reliable. Workaround that works: loadFont({ uri: 'file:///system/fonts/NotoSansThai-Regular.ttf' }) (routed to loadFontFromURL, which handles file://).

2. systemFallback() is not script-aware — HybridDefaultFallbackFont resolves to FontHelper.getFallbackFontBytes(FontOpts(weight)), i.e. the default family (Roboto), which cannot cover non-Latin scripts. Per-script resolution (like iOS does natively) would make systemFallback() a real safety net.

Environment

  • @rive-app/react-native 0.4.10 (rive-android 11.4.0) and 0.4.19 — same code in HybridRiveFontConfig.applyFallbackFonts
  • React Native 0.85/0.86, new arch, Hermes, Android
主要语言
TypeScript
星标
157
派生
17
平均合并
1 天 10 小时
30 天内合并 PR
20

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

rive-app/rive-nitro-react-native 的其他 Issue

查看 rive-app/rive-nitro-react-native 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。