Signup links and field refs drop ø, æ, ß and ł
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 75/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- backend
调研方向
阅读src/lib/kebab.ts和src/lib/slug.test.ts中的现有用例，然后检查 issue 中提到的 slot 和 field 测试。为列出的字母添加覆盖，同时保留 å、ä 和 ö 当前的输出。新映射得到覆盖，且列出的 lint、typecheck、knip 和 test 命令均通过后，即表示完成。
由索引模型根据 Issue 内容生成。
描述
Needs your OK: this changes how the web addresses of new signups, and the refs of new fields and slots, are made from text with these letters. Existing links don't change. Swap pipeline:proposed for pipeline:ready to have it built.
What happens
toKebab in src/lib/kebab.ts turns text into the kebab-case behind signup slugs, workspace slugs, slot refs and field refs. It strips accents with NFKD, which works for å, ä, ö, é and ü, but some letters don't decompose and are dropped or split the word:
- "Smørrebrød" →
sm-rrebr-d - "Æblekage" →
blekage - "Straße" →
stra-e - "Łódź" →
odz
So Danish, Norwegian, German and Polish titles get broken-looking links. Non-Latin titles (Cyrillic, Greek, Chinese) come out empty and fall back to signup, field or slot, which is fine for now.
Fix, in outline
- Map the letters that don't decompose, before NFKD: ø→o, æ→ae, œ→oe, ß→ss, ł→l, đ→d, þ→th, ð→d, in upper and lower case.
- Leave non-Latin scripts on the fallback.
Watch for
- Existing slugs and refs never change.
toSlugandtoFieldRefare only called to make new values (pickAvailableSluginsrc/services/signups.ts, the slot ref insrc/services/slots.ts, the workspace slug insrc/auth/adapter.ts), so nothing re-derives a stored one. - No Node imports.
toKebabis shared with the builder in the browser. - Tests pin today's outputs (
src/lib/slug.test.tsand the slot-field tests).
Order
None. This can be built any time; it should land before Danish or Norwegian ship.
Done when
- Unit tests cover each mapped letter, and å, ä and ö come out as before.
pnpm lint && pnpm typecheck && pnpm knip && pnpm testpass.
Planned with the owner in https://claude.ai/code/session_01EFKmj716ZY3b3SwR8TV8Y2 and checked against the code on main at 35288fa. The full plan is private to the owner's account: https://claude.ai/artifact/VgQH6U2s2EVx3LX991fJi8 (a Claude session on that account can open it with the Artifact tool's read action). It's in phase 4 there.
- 主要语言
- TypeScript
- 星标
- 19
- 派生
- 4
- 平均合并
- 20 小时 9 分钟
- 30 天内合并 PR
- 156
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
richshaw/OpenSignup 的其他 Issue
-
enhancement pipeline:proposed pipeline:ux
难度 2/5 1-3 小时 新手友好度 72/100
richshaw/OpenSignup#654 ·
维护者通常 1 天内回复
-
enhancement pipeline:proposed pipeline:ux
难度 2/5 1-3 小时 新手友好度 82/100
richshaw/OpenSignup#653 ·
维护者通常 1 天内回复
-
enhancement pipeline:proposed pipeline:ux
难度 2/5 1-3 小时 新手友好度 78/100
richshaw/OpenSignup#652 ·
维护者通常 1 天内回复
-
enhancement good first issue pipeline:ready
难度 2/5 1-3 小时 新手友好度 82/100
richshaw/OpenSignup#645 ·
维护者通常 1 天内回复
-
bug good first issue pipeline:ready pipeline:ux
难度 2/5 1-3 小时 新手友好度 88/100
richshaw/OpenSignup#644 ·
维护者通常 1 天内回复
查看 richshaw/OpenSignup 的全部 Issue
相似的 Issue
-
type: bug
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
0️⃣ phase/new
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 70/100
microsoft/playwright#43640 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100