bregctl dev: a detached supervisor can inherit another start's output pipe, hanging parallel installed-dev tests
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with crates/registry-bregctl/tests/dev_lifecycle.rs and trace Session::start() and run_supervisor() to see how the detached process handles inherited file descriptors. Review the macOS process spawning path and reproduce by running the installed-dev tests in parallel. Done when concurrent starts return within a bound and the regression test passes.
由索引模型根据 Issue 内容生成。
描述
What happens
Running the installed-dev tests in crates/registry-bregctl/tests/dev_lifecycle.rs in parallel can hang one test indefinitely on macOS. The hung test is waiting in Command::output() for EOF on its child's stdout pipe. lsof during a hang showed the write end of that pipe held open by a different test's detached bregctl dev supervisor and the breg server it started, so the read never ends.
Likely cause (medium-high confidence)
On macOS, Rust's standard library creates pipes with pipe() and sets FD_CLOEXEC afterwards, which is not atomic. When two threads call Session::start() at once, one bregctl dev start child can inherit the other thread's pipe write end before FD_CLOEXEC is set. That child then hands the descriptor to its detached supervisor (run_supervisor calls setsid() but keeps inherited descriptors), which keeps it open for the life of the dev environment. The fd numbers matched; the fork itself was not caught.
The same inheritance would affect an operator who starts two dev environments from one parent process, though that is less likely outside tests.
Candidate fixes
- When detaching the supervisor, close every inherited descriptor above 2 (or reopen 0 to 2 on
/dev/nulland close the rest). - Or spawn the supervisor with
posix_spawnandPOSIX_SPAWN_CLOEXEC_DEFAULT, passing only the descriptors it needs.
A regression test can start two sessions concurrently and assert that each dev start returns within a bound.
Found while verifying the external record projections branch (feat/breg-external-views).
- 主要语言
- Rust
- 星标
- 2
- 派生
- 0
- 平均合并
- 9 小时 48 分钟
- 30 天内合并 PR
- 151
环境准备
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
registrystack/registry-stack 的其他 Issue
-
area:breg enhancement
难度 2/5 1-3 小时 新手友好度 65/100
registrystack/registry-stack#2765 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
registrystack/registry-stack#2761 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
registrystack/registry-stack#2743 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
registrystack/registry-stack#2706 ·
维护者通常 1 天内回复
-
macOS contributor gates: Messaging config tests fail under the symlinked macOS temporary directory未关闭
难度 2/5 1-3 小时 新手友好度 83/100
registrystack/registry-stack#2704 ·
维护者通常 1 天内回复
查看 registrystack/registry-stack 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
AstrBotDevs/AstrBot-desktop#197 ·
-
难度 1/5 1 小时以内 新手友好度 75/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 82/100
stackabletech/airflow-operator#898 ·
维护者通常 1 天内回复
-
2 advisory ignore entries no longer match anything (`bytes`, `time` already patched in `Cargo.lock`)可能已有人在做 @zyl71 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 88/100