feat(ibmcloud): remove public gateway from VPC network module — use FIP-only for outbound

未关闭
#936 4 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 4 天内回复

@adrianriobo 已经在做这个了。

开始于 2026年10月16日。

评估

这个 Issue 还没有评估数据。

描述

provider/IBMCLOUD wontfix

Background

Every IBM Cloud VPC target that uses network.New() (kind, snc, ibm-z, ibm-gaudi) provisions two outbound internet paths:

  1. Public Gateway — subnet-level; all instances in the subnet can reach the internet immediately from first boot.
  2. Floating IP — instance-level 1:1 NAT; provides both inbound SSH/API access and outbound internet once attached.

The floating IP alone is sufficient for outbound connectivity. Once it is associated with an instance's NIC, the instance uses the FIP's public address for all outbound traffic — no gateway needed.

Why the gateway exists today

The Pulumi resource graph attaches the floating IP after the instance is created (it needs the NIC ID):

network.New() → FIP reserved (not yet attached)
↓
NewIsInstance() → VM boots, cloud-init starts
↓
NewIsInstanceNetworkInterfaceFloatingIp() → FIP attached

There is a window between "instance running" and "FIP associated" during which cloud-init runs apt-get update and downloads the kind binary and node image. Without the public gateway that window has no outbound internet path and cloud-init fails.

The gateway is attached to the subnet before the instance exists, so it covers that window reliably.

Opportunity

The IBM Cloud VPC REST API accepts primary_network_interface.floating_ips[] during instance creation, allowing the FIP to be associated atomically — the instance would boot with the FIP already wired, eliminating the race window entirely.

If the Pulumi IBM Cloud provider exposed this field on IsInstancePrimaryNetworkInterfaceArgs, we could:

  • Pass the pre-created FIP ID at instance creation time
  • Drop the separate IsInstanceNetworkInterfaceFloatingIp resource
  • Remove the public gateway and its subnet attachment entirely

Current blocker

IsInstancePrimaryNetworkInterfaceArgs in pulumi-ibmcloud v0.0.16 does not include a FloatingIps field:

type IsInstancePrimaryNetworkInterfaceArgs struct {
    AllowIpSpoofing    pulumi.BoolPtrInput
    Name               pulumi.StringPtrInput
    PrimaryIp          IsInstancePrimaryNetworkInterfacePrimaryIpPtrInput
    SecurityGroups     pulumi.StringArrayInput
    Subnet             pulumi.StringInput
    // FloatingIps missing — IBM Cloud API supports this
}

Cost and simplification benefit

  • One fewer VPC resource per stack (public gateway + subnet attachment): reduces IBM Cloud VPC resource quota consumption and simplifies teardown.
  • Public gateways themselves are not charged hourly by IBM Cloud, but data egress through them is billed at the same rate as through a FIP. Net cost saving is minimal but quota consumption drops.
  • The main gain is architectural simplicity: a single outbound path (the FIP) instead of two overlapping ones.

Proposed path

  1. Open an issue or PR against mapt-oss/pulumi-ibmcloud to expose FloatingIps []string on IsInstancePrimaryNetworkInterfaceArgs.
  2. Once the SDK is updated, refactor network.New() to:
    • Accept the pre-created FIP ID
    • Pass it in PrimaryNetworkInterface.FloatingIps
    • Remove NewIsPublicGateway and NewIsSubnetPublicGatewayAttachment
    • Remove the separate NewIsInstanceNetworkInterfaceFloatingIp call from each action
主要语言
Go
星标
25
派生
41
平均合并
5 天 3 小时
30 天内合并 PR
16

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

redhat-developer/mapt 的其他 Issue

查看 redhat-developer/mapt 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。