withImportNames() reports a change on a short name already imported next to a same-short-name alias
还没有人认领这个 Issue。
评估
调研方向
Look at NameImporter::resolveNameInUse() and NameImportingPostRector. The bug is about detecting a false positive change when a short name is already imported and a same-short-name alias appears later. Start by understanding the import resolution logic, then write a test with the provided minimal code to reproduce the issue. 'Done' means the file is not listed in changed_files on a dry-run when the output is identical.
由索引模型根据 Issue 内容生成。
描述
Bug Report
| Subject | Details |
|---|---|
| Rector version | 2.6.7, also on current main |
With withImportNames(), a class already used by its short name is reported as changed when another class with the same short name is imported under an alias after it.
The output is identical, but the file is counted as changed. With --dry-run it is never cached, so it is processed again on every run. With the aliased import first, nothing is reported.
Minimal PHP Code Causing Issue
namespace App;
use App\Dto\Response;
use App\Client\Response as ClientResponse;
final class SomeService
{
public function map(ClientResponse $clientResponse): Response
{
return new Response();
}
}
vendor/bin/rector process --dry-run --output-format=json lists the file under changed_files, with "changed_files": 0 in totals and NameImportingPostRector in changes, on every run.
NameImporter::resolveNameInUse() matches App\Client\Response as ClientResponse by its short name and returns Response, which is already what the code says.
Expected Behaviour
No change reported, the file is cached.
🤖 Drafted with AI assistance.
- 主要语言
- PHP
- 星标
- 10.4k
- 派生
- 742
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
rectorphp/rector 的其他 Issue
-
FileCacheStorage uses copy() instead of rename(), corrupting cache files on parallel cold-cache runs未关闭bug
难度 2/5 1-3 小时 新手友好度 78/100
-
bug
难度 3/5 1-2 天 新手友好度 55/100
相似的 Issue
-
sync-en
难度 1/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
good first issue
难度 2/5 1-3 小时 新手友好度 68/100
az-digital/az_quickstart#6077 ·
维护者通常 1 天内回复
-
Toolkit
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
[Bug] v-quick-install-app install crashes with ValueError if no supported PHP version is installed未关闭
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
Add `kjkpc.net`未关闭
难度 1/5 1 小时以内 新手友好度 72/100
FGRibreau/mailchecker#625 ·