Deprecation of `Toolbar` in favor of new `Flex` component

未关闭
  • 哪里不对？
#600 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@adamkudrna 已经在做这个了。

开始于 2025年3月10日。

评估

这个 Issue 还没有评估数据。

描述

feature

Today we discussed that Toolbar and ToolbarGroup have dense prop (and that we would like to get rid of ToolbarItem in future if possible). When we look at Grid component, we can see that there are columnGap and rowGap props available. We decided we want to deprecate dense prop and replace it with gap prop. If we want to match Grid props, I would suggest to have columnGap and rowGap instead of gap as it would be better for end-user and we currently have scenarios in which those two gaps can differs.

I thought I would be able to introduce those props easily, but I found out that it would be better to refactor whole Toolbar component and its subcomponents. Why? If you compare Toolbar and Grid props, you can spot the difference:

Grid:

Image

Toolbar:

Image

Grid is far more advanced than Toolbar is. It would be better to abstract logic from Grid and use it with Toolbar. That would cleanToolbar code, but it would require the change of shape of the props as Grid allows to specify value per breakpoint.

If we touch the props, it would be also good to unify naming to have same props for Grid and for Toolbar as they are same on CSS level.

That being said, this would require far more work than simply deprecating dense prop. At this stage, it would be better (in my opinion) to deprecate whole Toolbar component and to finally introduce Flex component we wanted to introduce anyway.

We wanted Flex component and this is the time we can solve more problems with it. We should leave Toolbar deprecated until 1.0.0 is released for smoother transition.

This is my recommendation after quick attempt to solve dense-related issue. What do you think @adamkudrna @mbohal?

主要语言
TypeScript
星标
23
派生
10
平均合并
5 天 12 小时
30 天内合并 PR
9

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

react-ui-org/react-ui 的其他 Issue

查看 react-ui-org/react-ui 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。