Suggested API: on_conflict: :replace
维护者通常 4 天内回复
还没有人认领这个 Issue。
评估
调研方向
The payload names no files or tests. Start from the existing on_conflict: :discard path used by limits_concurrency, then trace how a pending job is stored and identified by its concurrency key. Decide the semantics for :replace and whether payload batching is included, then add coverage for first-wins versus last-wins behavior. Done means the new option is implemented, documented, and tested for duplicate enqueues while a matching job is still waiting.
由索引模型根据 Issue 内容生成。
描述
Description
Currently, Solid Queue provides an on_conflict: :discard option to enforce uniqueness. This follows a "first wins" behavior, where subsequent duplicate jobs are dropped if a matching job is already pending in the queue.
However, many use cases (such as syncing the latest user state or syncing inventory) require a "last value wins" strategy. If a new job with the exact same concurrency key is enqueued while a previous one is still waiting, the queue should ensure that only the latest job (carrying the freshest payload) is processed. This can be achieved either by replacing the pending job entirely or updating its payload.
Introducing this strategy would also significantly boost performance under high-frequency updates, as it prevents the system from wasting database and worker cycles processing outdated intermediate payloads.
Examples from other queue managers
• Sidekiq Enterprise / Sidekiq Unique Jobs: Supports options like on_conflict: :replace or rescheduling to overwrite the payload of an un-executed job with the freshest data.
• Lowkiq: Passes an array of all enqueued payloads directly to the perform method, allowing the developer to decide how to process or batch them.
Suggested API
It would be useful to introduce a configuration option to define how concurrency conflicts are handled:
Option A: Pure :replace strategy
class UpdateInventoryJob < ApplicationJob
limits_concurrency to: 1, key: ->(payload) { payload.id }, on_conflict: :replace
def perform(payload)
# ...
end
end
Option B: Custom conflict hook with payload batching
class UpdateInventoryJob < ApplicationJob
limits_concurrency to: 1, key: ->(product) { product.id }, on_conflict: :replace
def perform_on_conflict(payloads)
# Allows manually processing the final state
perform(payloads.last)
end
end
- 主要语言
- Ruby
- 星标
- 2.5k
- 派生
- 271
- 平均合并
- 5 天 6 小时
- 30 天内合并 PR
- 5
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
rails/solid_queue 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
rails/solid_queue#838 ·
维护者通常 4 天内回复
-
难度 5/5 一周以上 新手友好度 45/100
rails/solid_queue#836 ·
维护者通常 4 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
rails/solid_queue#834 · 1 条评论 ·
维护者通常 4 天内回复
-
难度 5/5 一周以上 新手友好度 42/100
rails/solid_queue#808 · 3 条评论 ·
维护者通常 4 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
rails/solid_queue#806 ·
维护者通常 4 天内回复
查看 rails/solid_queue 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
jenkins-infra/jenkins.io#9615 · 1 条评论 ·
维护者通常 1 天内回复
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtime可能已有人在做 @Goldziher 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
WhatsApp Cloud template sync saves a partial template list when one page of the Graph API response fails可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 60/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 91/100
simp/pupmod-simp-ssh#270 ·