Windows: `quarto.path` pointing at a `.cmd`-only dev binary is detected as a file but silently falls back to PATH
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 70/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- typescript
- 领域
- devtools
调研方向
Start in packages/quarto-core/src/context.ts, reading detectUserSpecifiedQuarto, detectQuarto, readQuartoInfo, and the useCmd handling around the referenced lines. Reproduce the Windows setup with package/dist/bin/quarto.cmd and the quarto.path setting, then verify that the configured .cmd binary is version-probed and selected rather than silently falling back to PATH.
由索引模型根据 Issue 内容生成。
描述
When the user sets quarto.path to an absolute path of a Quarto build that ships only quarto.cmd on Windows (typical for the in-repo dev binary at package/dist/bin/quarto.cmd after ./configure.cmd), the extension's existence check passes but the subsequent version probe fails. The extension then silently falls back to the system PATH, so the user-specified dev binary is never actually used.
Mechanism
detectUserSpecifiedQuarto validates the file exists and is a file (passes for quarto.cmd), then calls detectQuarto(quartoPath):
readQuartoInfo calls execProgram(quartoPath, ["--version"]). On Windows, child_process spawn on an absolute path to a .cmd file fails without shell: true because Windows requires cmd.exe to interpret .cmd files. The catch block retries with quartoPath + ".cmd" — but when the user already passed …\quarto.cmd, the retry becomes …\quarto.cmd.cmd, which does not exist. Both attempts fail, detectQuarto returns undefined, and the extension falls through to the PATH branch.
There is no warning surfaced — detectUserSpecifiedQuarto only warns when fs.existsSync or isFile checks fail, not when the version probe silently fails:
The useCmd flag only adjusts the execution-time path; it does not help at detection time:
Reproduction
On Windows:
- Clone
quarto-dev/quarto-cli, run./configure.cmd. This producespackage/dist/bin/quarto.cmdwith noquarto.exesibling. - In Positron/VS Code settings, set
quarto.pathto the absolute path of thatquarto.cmd. - Reload the window.
- Open a
.qmdand run any Quarto extension command (Preview, Verify Installation, render).
Observed: the dev binary is not used. The extension picks up whatever quarto is on PATH (in my case, a quarto-prerelease install from Scoop).
Quarto output channel log
[info] Activating Quarto extension.
[info] Searching for Quarto CLI...
[info] Checking quarto.path setting: C:/Users/chris/Documents/DEV_R/quarto-cli.worktrees/issue-14533/package/dist/bin/quarto.cmd
[info] Checking system PATH...
[info] Found Quarto 1.10.3 on system PATH
[info] Using Quarto 1.10.3 from C:\Users\chris\scoop\apps\quarto-prerelease\current\bin (found on system PATH)
[info] Activated Quarto extension.
Note: no warning between the quarto.path check and the PATH fallback. The user has no diagnostic indicating their setting was discarded.
Suggestion
We could either:
- Detect a trailing
.cmdonquartoPathat detection time and spawn withshell: true(or wrap incmd /c). - Or trim the trailing
.cmdfromquartoPathbefore passing toreadQuartoInfo, so the fallback at L208 can append.cmdcleanly without producingquarto.cmd.cmd. - Or at minimum, surface a warning when the existence check passes but the version probe fails, so users get a clear diagnostic instead of silent fallback.
This blocks testing dev binaries against the extension end-to-end on Windows, which is what I hit while validating a quarto-cli fix that surfaces only when the extension is the client. Related to #352, which describes a different mechanism (terminal env-var prepend race on non-bash shells) producing the same user-visible symptom ("quarto.path is ignored").
- 主要语言
- TypeScript
- 星标
- 652
- 派生
- 64
- 平均合并
- 8 小时 45 分钟
- 30 天内合并 PR
- 36
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
quarto-dev/quarto 的其他 Issue
-
VS Code extension: `quarto preview` fails when the file path contains parentheses (path not shell-quoted)可能已有人在做 @Bondrewd-K 于 5 天前认领。 未关闭bug vscode
难度 2/5 1-3 小时 新手友好度 78/100
quarto-dev/quarto#1194 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
quarto-dev/quarto#1139 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 90/100
quarto-dev/quarto#1138 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
quarto-dev/quarto#1137 ·
维护者通常 1 天内回复
-
Add dependabot?可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
quarto-dev/quarto#1135 ·
维护者通常 1 天内回复
查看 quarto-dev/quarto 的全部 Issue
相似的 Issue
-
check:passed streams:add
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
vercel-labs/wterm#246 ·
维护者通常 1 天内回复
-
bug ready-for-agent
难度 2/5 1-3 小时 新手友好度 70/100
nearform/lastlight#452 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
fix(console): include PARTITIONED BY in generated table DDL可能已有人在做 @aubdiy 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
apache/polaris-tools#291 ·
维护者通常 6 天内回复