CI: packaging workflow misses most extension workspaces; yarn lint never runs
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- github-actions, typescript
- 领域
- build-system, ci-cd, testing-qa
调研方向
Read .github/workflows/build.yaml and test-positron.yaml, then compare test.yaml and the workspace dependencies described in the issue. Verify which extension workspaces and root manifests need coverage, and run yarn lint to assess the current backlog. Done means packaging and Positron checks trigger for relevant changes and lint is run in CI with the agreed blocking behavior.
由索引模型根据 Issue 内容生成。
描述
Problem
Two CI coverage gaps:
1. build.yaml path filter is too narrow
.github/workflows/build.yaml ("Build VS Code Extension", which runs vsce package) only triggers on:
paths:
- 'apps/lsp/**'
- 'apps/vscode/**'
The packaged extension also bundles apps/vscode-editor, apps/vscode-markdownit, apps/quarto-utils, and most of packages/* (core, editor-*, quarto-core, _-prefixed packages, build, tsconfig, eslint configs). It also depends on root package.json, yarn.lock and turbo.json. A PR that touches only those files doesn't get a packaging check. test-positron.yaml has the same problem (it only triggers on apps/vscode/**).
test.yaml has no path filter, so tests do run. The gap is specifically that packaging and Positron tests don't run.
Fix: widen paths to cover every workspace in the extension's dependency closure plus the root manifests, or drop the path filter.
2. yarn lint never runs in CI
No workflow runs yarn lint, so lint errors build up unnoticed. Running it today will probably surface a backlog. Either fix those first, or add the job as non-blocking at first.
Fix: add a lint job to test.yaml (after yarn install). Consider doing this together with, or right after, the ESLint 10 flat-config migration (deps-upgrade-eslint-prettier.md), so we don't fix lint errors under a config that's about to be replaced.
Related
The yarn install --immutable --immutable-cache --check-cache flags used in these workflows are Yarn 2+ only, and Yarn 1 ignores them, so CI doesn't enforce the lockfile. That's tracked as the first step of the dependency-upgrade plan and should be fixed alongside this.
Found during the dependency-upgrade research.
- 主要语言
- TypeScript
- 星标
- 655
- 派生
- 64
- 平均合并
- 22 小时 16 分钟
- 30 天内合并 PR
- 42
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
quarto-dev/quarto 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
quarto-dev/quarto#1139 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 90/100
quarto-dev/quarto#1138 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
quarto-dev/quarto#1137 ·
维护者通常 1 天内回复
-
Add dependabot?可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
quarto-dev/quarto#1135 ·
维护者通常 1 天内回复
-
AceNodeView: programmatic setSelection() marks the cursor dirty, scrolling the document to the front matter可能已有人在做 @kevinushey 于 55 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 90/100
quarto-dev/quarto#1099 ·
维护者通常 1 天内回复
查看 quarto-dev/quarto 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
logancyang/obsidian-copilot#3753 ·
维护者通常 1 天内回复
-
area: presentation severity: important
难度 2/5 1-3 小时 新手友好度 85/100
voithos-labs/aragonite#763 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
diegosouzapw/OmniRoute#17386 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 半天 新手友好度 72/100
super-productivity/super-productivity#10982 · 1 条评论 ·
维护者通常 1 天内回复