platform: import _wmi on first use

未关闭 适合新手
#161,513 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
76/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
python

调研方向

阅读 Lib/platform.py,尤其是模块级的 _wmi 导入和 _wmi_query();issue 中包含一项拟议更改和测得的行为。检查 test_platform 和 test_wmi 测试,然后确认导入 platform 时不会加载 _wmi,并且所述 Windows 辅助函数仍返回相同的值。

由索引模型根据 Issue 内容生成。

描述

OS-windows performance stdlib type-feature
Feature or enhancement

Lib/platform.py imports _wmi at module level on Windows. _wmi.pyd loads oleaut32.dll and propsys.dll (with _wmi.pyd itself and their dependencies, 7 more images in the process), but WMI is only queried by win32_ver(), version(), release(), uname() and the processor/machine helpers. Code that only imports platform, or calls python_version() or system(), pays for it anyway. pytest is one example: it imports platform on every run.

Moving the import into _wmi_query() (keeping the "unavailable" state so a failed import or query is not retried):

60 runs each, perf_counter around the import before after difference
import platform 18.6 ms 12.9 ms −5.5 ms [−6.0, −5.1]
import pytest 206 ms 196 ms −9.5 ms [−13.6, −4.7]

(python-build-standalone 3.14.4, Windows 11 26100.) win32_ver(), uname(), machine(), version() and processor() return the same values; test_platform and test_wmi pass.

The change, against main (2781ffe1f2):

diff --git a/Lib/platform.py b/Lib/platform.py
index c87bf2f..375acc2 100644
--- a/Lib/platform.py
+++ b/Lib/platform.py
@@ -114,10 +114,10 @@ import sys
 import functools
 import itertools
 lazy import warnings
-try:
-    import _wmi
-except ImportError:
-    _wmi = None
+# _wmi is imported on first use (see _wmi_query): loading it maps the OLE
+# and property-system DLLs, which most users of this module never need.
+# None means not imported yet, False means unavailable.
+_wmi = None
 
 ### Globals & Constants
 
@@ -332,6 +332,12 @@ def _syscmd_ver(system='', release='', version='',
 
 def _wmi_query(table, *keys):
     global _wmi
+    if _wmi is None:
+        try:
+            import _wmi as wmi
+        except ImportError:
+            wmi = False
+        _wmi = wmi
     if not _wmi:
         raise OSError("not supported")
     table = {
@@ -344,7 +350,7 @@ def _wmi_query(table, *keys):
             table,
         )).split("\0")
     except OSError:
-        _wmi = None
+        _wmi = False
         raise OSError("not supported")
     split_data = (i.partition("=") for i in data)
     dict_data = {i[0]: i[2] for i in split_data}

(PEP 810's lazy import doesn't fit here because the import sits in try/except ImportError.)

I used GitHub Copilot (Claude Opus 5.5 model) to trace this, build and time the prototype, and draft this issue. The measurements were run on my machine.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

主要语言
Python
星标
77.9k
派生
37.1k
平均合并
17 小时 43 分钟
30 天内合并 PR
675

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。