asyncio: SSL transport raises AttributeError after close() in connection_lost()

已关闭
  • 哪里不对？
#160,964 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
networking

调研方向

Start by locating _SSLProtocolTransport.close() and the asyncio SSL transport tests; the issue identifies that method as the source and includes a reproduction. Check the behavior of write(), set_protocol(), get_write_buffer_size(), get_extra_info() and the sendfile() fallback after close; done means these paths no longer raise the reported AttributeError and the fallback reports the expected connection error.

由索引模型根据 Issue 内容生成。

描述

stdlib topic-asyncio type-bug

Bug report

If a protocol closes its SSL transport in connection_lost(), which is a common pattern, later calls on the transport fail:

import asyncio
from test.test_asyncio import utils as tu

class Proto(asyncio.Protocol):
    def connection_made(self, tr):
        self.tr = tr
    def connection_lost(self, exc):
        self.tr.close()
        self.lost.set_result(None)

async def main():
    async def handler(reader, writer):
        writer.close()
    srv = await asyncio.start_server(handler, '127.0.0.1', 0,
                                     ssl=tu.simple_server_sslcontext())
    port = srv.sockets[0].getsockname()[1]
    loop = asyncio.get_running_loop()
    proto = Proto()
    proto.lost = loop.create_future()
    tr, _ = await loop.create_connection(
        lambda: proto, '127.0.0.1', port, ssl=tu.simple_client_sslcontext())
    await proto.lost
    tr.write(b'x')  # AttributeError: 'NoneType' object has no attribute '_write_appdata'
    srv.close()

asyncio.run(main())

set_protocol(), get_write_buffer_size() and get_extra_info() fail the same way. Plain TCP transports don't have this problem.

It also breaks the loop.sendfile() fallback over SSL: if the peer disconnects mid-transfer, restore() calls set_protocol() and raises AttributeError instead of the expected connection error.

The cause is in _SSLProtocolTransport.close(). When it's called on a transport already marked closed, it sets _ssl_protocol = None. That was added in gh-98539 so the transport doesn't keep the SSL context alive, but it leaves the transport unusable.

Affects 3.11 and later.

Linked PRs
  • gh-160965
主要语言
Python
星标
77.8k
派生
37.7k
平均合并
17 小时 24 分钟
30 天内合并 PR
716

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。