compile: double free of pc->fail_pop in codegen_pattern_or on allocation failure with nested or-pattern

未关闭
  • 哪里不对？
#160,789 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
compilers

调研方向

Start in Python/codegen.c at codegen_pattern_or and codegen_match, using the reported lines 6573 and 6775 to trace ownership of fail_pop through the allocation failure path. Reproduce with the provided _testcapi.call_with_nomemory script on an ASan build; done when injected failures raise MemoryError, the pointer is freed once, and the script prints “survived.”

由索引模型根据 Issue 内容生成。

描述

interpreter-core type-crash

When an allocation fails while compiling a match statement whose or-pattern contains another or-pattern, codegen_pattern_or frees pc->fail_pop and codegen_match then frees it again, so compile() crashes instead of raising MemoryError.

The failure is injected with the test-only _testcapi.call_with_nomemory:

import ast, _testcapi
tree = ast.parse('def f(x):\n match x:\n  case [1|2] | 3: pass\n')
for off in range(1500):
    held = None
    held = [[] for _ in range(128)]   # refill/empty the list freelist so PyList_New in codegen really allocates
    try:
        _testcapi.call_with_nomemory(off, off + 1, compile, tree, 'a.py', 'exec')
    except (MemoryError, SyntaxError):
        pass
print('survived')

Saved as input.py and run on an ASan build that includes _testcapi:

python input.py

Output:

ERROR: AddressSanitizer: heap-use-after-free on address 0x503000002988
READ of size 1 at 0x503000002988 thread T0
    #0 in _PyMem_DebugCheckAddress Objects/obmalloc.c:3351
    #4 in PyMem_Free Objects/obmalloc.c:1292
    #5 in codegen_match Python/codegen.c:6775
...
freed by thread T0 here:
    #5 in PyMem_Free Objects/obmalloc.c:1292
    #6 in codegen_pattern_or Python/codegen.c:6573

Every injected failure should surface as MemoryError from compile(), with the pointer freed once, and the script should print survived.

Found at commit 3646ea571f3d8290806a3029d555b179f8be1539. It still reproduces at 3acc941f2b72 (latest upstream checked): ASan heap-use-after-free in the checking build, and the release build segfaults (exit code 139). case (1|2) | 3, where the inner or-pattern is not inside a sequence pattern, survives.

Looks like in the inner codegen_pattern_or, old_pc = *pc copies the outer fail_pop array, and if the first PyList_New(0) in the loop fails, goto error runs before pc->fail_pop = NULL. The error block then frees old_pc.fail_pop while pc->fail_pop still points to it, and codegen_match frees it again.

Found with an LLM-based testing tool; I used Claude to reduce it and look for the cause.

Linked PRs
  • gh-160875
主要语言
Python
星标
77.8k
派生
37.7k
平均合并
17 小时 24 分钟
30 天内合并 PR
716

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。