Only top-level objects are validated

未关闭
#77 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
openapi, python
领域
api, testing

调研方向

Start by tracing how required properties are validated for schemas nested inside array items and other object properties. Add regression cases matching the invalid array-item and nested-object examples, then verify validation rejects required names missing from properties while preserving the existing top-level behavior.

由索引模型根据 Issue 内容生成。

描述

kind/bug/confirmed

Validation should fail when an object has an item in the required list that isn't defined in properties.

Validation fails as expected when an object is defined on the top level:

openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /my-pet:
    get:
      summary: A pet
      operationId: getPet
      tags:
        - pets
      responses:
        '200':
          description: A pet
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pet"
components:
  schemas:
    Pet:
      type: object
      required:
        - name
        - undefinedRequiredItem # This item is not defined in properties, FAIL validation
      properties:
        name:
          type: string
> Required list has not defined properties: ['undefinedRequiredItem']

BUG: Validation passes for an invalid object used as an array item:

openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /pets:
    get:
      summary: List all pets
      operationId: listPets
      tags:
        - pets
      responses:
        '200':
          description: Array of pets
          content:
            application/json:    
              schema:
                $ref: "#/components/schemas/Pets"
components:
  schemas:
    Pets:
      type: array
      items:
        type: object
        required:
          - name
          - undefinedRequiredItem # This item is not defined in properties, but validation passes
        properties:
          name:
            type: string
> OK

BUG: Validation passes for an invalid nested object:

openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /my-pet:
    get:
      summary: A pet
      operationId: getPet
      tags:
        - pets
      responses:
        '200':
          description: A pet
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pet"
components:
  schemas:
    Pet:
      type: object
      properties:
        pet:
          type: object
          required:
            - name
            - undefinedRequiredItem # This item is not defined in properties, but validation passes
          properties:
            name:
              type: string
> OK
主要语言
Python
星标
409
派生
73
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

python-openapi/openapi-spec-validator 的其他 Issue

查看 python-openapi/openapi-spec-validator 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。