A public way to add feature definitions to FeatureSet

未关闭
#842 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
56/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
api

调研方向

Start by reading FeatureSet, especially find_feature() and feature_tree(), then inspect caldav_server_tester/future_features.py to see how definitions are currently added. Done means a public register_features(definitions) method adds missing definitions, keeps caldav's definitions when names overlap, clears the relevant caches, and returns the names added.

由索引模型根据 Issue 内容生成。

描述

Disclaimer: AI-generated text below the line, generated by Claude Opus 5.5, from the prompt(s):

The problem is that the compatibility tree cannot be edited without also releasing the caldav library. However, this is big friction, perhaps we should find some workaround in 1.7.0. Like, having a FUTURE_FEATURES dict that contains not-yet-released changes in the caldav library, and then patch up caldav.compatibility_hints.FEATURES |= FUTURE_FEATURES, could that work out?


A new probe in caldav-server-tester needs a feature definition in FeatureSet.FEATURES, and that can only change with a caldav release. To get past this, the tester now carries the definitions caldav has not released yet (FUTURE_FEATURES in caldav_server_tester/future_features.py) and adds them to FeatureSet.FEATURES when it is imported.

That works, but it depends on caldav internals: find_feature() caches subfeatures inside the definitions and feature_tree() caches _feature_tree, so the tester has to clear both, or a parent looked up before the patch never lists its new child.

Suggestion: a class method such as FeatureSet.register_features(definitions: dict) -> list[str] that adds the definitions caldav lacks, keeps caldav's own where both define a feature, clears the caches, and returns the names it added. The tester would then call that instead of patching the class.

主要语言
Python
星标
412
派生
113
平均合并
9 小时 21 分钟
30 天内合并 PR
77

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

python-caldav/caldav 的其他 Issue

查看 python-caldav/caldav 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。