save() increments SEQUENCE by default - wrong for sync and copy use cases
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start at CalendarObjectResource.save(), where increase_seqno defaults to True, then check the other save paths the issue names (add_event(), save_object()) for whether they forward the flag. The issue leaves the choice open: flip the default with a deprecation period, or keep it and document it. Get a maintainer decision before coding. Done means the chosen behaviour is applied consistently across the save paths and covered by tests.
由索引模型根据 Issue 内容生成。
描述
Disclaimer: AI-generated text below the line, generated by Claude Opus 5.5 (Claude Code), from the prompt:
https://github.com/pycalendar/calendaring-sync/pull/19 [and the design notes of the calendaring library] - please file the issues mentioned in that pull request
CalendarObjectResource.save() has increase_seqno=True as default, so every save of an object that has a SEQUENCE property bumps it.
RFC 5545 §3.8.7.4 has the organizer increment SEQUENCE for significant revisions, and RFC 5546 uses it to order scheduling messages. A sync engine or a copy/migrate tool that writes an object it read elsewhere is not making a revision: it must store the data unchanged, or the two sides diverge and every sync round bumps the number again. Cosmetic edits (fixing a typo in a description) arguably don't warrant a bump either.
Callers can pass increase_seqno=False, but the default surprises anyone who expects save() to save what they have.
Options:
- flip the default to
False(breaking, would need a deprecation period), or - keep it, but document it prominently and make sure every save path (
add_event(),save_object(), …) passes the flag through.
Found by calendaring-sync, which must disable it in its adapter: https://github.com/pycalendar/calendaring-sync/pull/19
Related discussion on implicit changes to objects: https://github.com/python-caldav/caldav/issues/613
- 主要语言
- Python
- 星标
- 412
- 派生
- 113
- 平均合并
- 22 小时 43 分钟
- 30 天内合并 PR
- 43
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
python-caldav/caldav 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
python-caldav/caldav#687 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
python-caldav/caldav#782 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
python-caldav/caldav#780 ·
维护者通常 1 天内回复
-
compatibility refactoring
难度 4/5 3-5 天 新手友好度 32/100
python-caldav/caldav#778 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 18/100
python-caldav/caldav#777 ·
维护者通常 1 天内回复
查看 python-caldav/caldav 的全部 Issue
相似的 Issue
-
area: tools documentation good first issue ready for a contributor
难度 2/5 1-3 小时 新手友好度 82/100
eyalgolan/statecraft-israel#873 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 5 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复