Improve documentation for ListT instances
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 30/100
- Issue 类型
- 文档
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
调研方向
Start by reading the ListT instances in the transformers package and compare their effect sequencing with the Compose List Effect examples in the issue. Document which sequencing behavior the instances provide and how it differs in the shown examples; done when the documentation explains the distinction clearly. The issue has had no comment for years, so check whether maintainers still want this work.
由索引模型根据 Issue 内容生成。
描述
What kind of effect-sequencing behavior is ListT supposed to exhibit? I ask because in haskell, ListT m a is a newtype wrapper of m [a], and if purescript's ListT is meant to be modeled after haskell's, ListT Effect Int should perhaps then behave like Effect [Int]. However, the haskell community has also considered alternative models for ListT like the following:
-- https://github.com/nikita-volkov/list-t/blob/master/library/ListT.hs
newtype ListT m a = ListT (m (Maybe (a, ListT m a)))
Because ListT in Pursuit's 'transformers' package is defined as ...
newtype ListT f a = ListT (f (Step a (ListT f a)))
data Step a s = Yield a (Lazy s) | Skip (Lazy s) | Done
... Volkov's ListT (shown above) seems to be the underlying model for purescript's own ListT.
What kind of effect-sequencing behavior, then, should Volkov's ListT exhibit? Unfortunately, at the moment, I can't experiment with his code directly; however, it seems that, under specific conditions, Volkov's ListT m Int should behave similarly to [m Int] -- in particular, when a list-like construct in either case (ListT m Int or [m Int]) is fully traversed/consumed with pre-order congruence and the final effect of ListT is pure or ignored. (Or at least I assume; perhaps there are details that invalidate this comparison.)
If this comparison is sound, users in purescript-land might expect values of the analogous purescript types ListT Effect Int, List (Effect Int) and Compose List Effect Int, under appropriate conditions, also to exhibit identical behavior. I'm not sure that's the case, however.
Consider, for example, product0 and product1 below:
import Control.Monad.List.Trans as T
-- other imports ...
io :: forall a b. Show b => b -> a -> Effect a
io x y = log (show x) *> pure y
-- `list0` and `list1` below are meant to have congruent sequences of data AND effects.
list0 :: ListT Effect Int
list0 = fromEffect (io 2 2) <|> fromEffect (io 1 1) <|> fromEffect (io 0 0) <|> T.nil
list1 :: Compose List Effect Int
list1 = Compose $ pure (io 2 2) <|> pure (io 1 1) <|> pure (io 0 0) <|> Nil
f0 :: ListT Effect (Int -> Int)
f0 = fromEffect (io "id" identity)
f1 :: Compose List Effect (Int -> Int)
f1 = Compose (pure (io "id" identity))
product0 = f0 <*> list0 :: ListT Effect Int
product1 = f1 <*> list1 :: Compose List Effect Int
If product0 and product1 are fully traversed, results like the following occur:
sequenceListT :: forall a. ListT Effect a -> Effect (List a)
sequenceListT = foldl' (\x y -> pure (x <> pure y)) Nil
sequenceCompose :: forall a. Compose List Effect a -> Effect (List a)
sequenceCompose = sequence <<< unwrap
-- PROMPT> sequenceListT product0
-- "id"
-- 2
-- 1
-- 0
-- (2 : 1 : 0 : Nil)
-- PROMPT> sequenceCompose product1
-- "id"
-- 2
-- "id"
-- 1
-- "id"
-- 0
-- (2 : 1 : 0 : Nil)
Other helpful comparisons to try might include the following:
product2 = T.nil <*> list0 :: ListT Effect Int
product3 = pure Nil <*> list1 :: Compose List Effect Int
product4 = Backwards f0 <*> Backwards list0 :: Backwards (ListT Effect) Int
product5 = Backwards f1 <*> Backwards list1 :: Backwards (Compose List Effect) Int
Although I've tried to model the same sequence of bundled data and effects as both an instance of ListT Effect Int and as an instance of Compose List Effect Int and although I (myself at least) expect similar behavior because of my assumptions listed above, the two values product0 and product1 have different overall effects when traversed.
The source of this difference in behavior appears to be related to the Apply typeclass. Whereas List's apply member has a static flavor, ListT's implementation of apply is monadic and therefore directionally biased.
I'm not sure which style of applicative multiplication might be generally preferable. I'm not even sure that List and ListT should have exactly identical effect-sequencing semantics (in relevant scenarios). However, because this difference in behavior surprised me at least, I figured I'd note this distinction as an issue for maintainers to consider. Perhaps it's a point confusing/interesting enough to include in documentation.
Thanks much
- 主要语言
- PureScript
- 星标
- 72
- 派生
- 43
- 平均合并
- 2 天 23 小时
- 30 天内合并 PR
- 1
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
purescript/purescript-transformers 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 52/100
-
type: breaking change
难度 4/5 3-5 天 新手友好度 35/100
purescript/purescript-transformers#144 · 2 条评论 ·
-
type: documentation
难度 1/5 1 小时以内 新手友好度 28/100
purescript/purescript-transformers#129 · 6 条评论 ·
-
type: enhancement
难度 5/5 一周以上 新手友好度 18/100
purescript/purescript-transformers#123 · 4 条评论 ·
-
maybeToExceptT未关闭type: enhancement
难度 2/5 1-3 小时 新手友好度 42/100
查看 purescript/purescript-transformers 的全部 Issue
相似的 Issue
-
bug
难度 1/5 1 小时以内 新手友好度 75/100
MetrolistGroup/Metrolist#4554 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
kubescape/node-agent#1099 ·
维护者通常 1 天内回复
-
15.0
难度 2/5 1-3 小时 新手友好度 62/100
-
[workshop-sim] Improve: Provide a concrete example and activity checks in agentic intro (step 5)未关闭feedback simulation workshop
难度 2/5 1-3 小时 新手友好度 68/100
githubnext/gh-aw-workshop#5715 ·
维护者通常 1 天内回复