Clarification of CatQueue implementation

未关闭
#22 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
48/100
Issue 类型
文档
描述清晰度
描述清楚
活跃度
停滞
领域
documentation

调研方向

Read the CatQueue implementation and its citation at src/Data/CatQueue.purs#L8, then compare the comment with the implementation described in the issue. Update the comment to cite the traditional two-list queue implementation accurately; done means the citation and description match the implementation.

由索引模型根据 Issue 内容生成。

描述

status: needs more info

The code for CatQueue cites Okasaki, 1995: https://github.com/purescript/purescript-catenable-lists/blob/da5091b9fcafe46284655336c66ee758e8e0e22c/src/Data/CatQueue.purs#L8

This is a bit puzzling, as the actual implementation is not the lazy-list based one proposed in that paper, but rather the more "traditional" implementation that Okasaki attributes to other authors:

The standard trick, reinvented many times (Hood and Melville, 1981; Gries, 1981;
Burton, 1982), is to represent the queue as a pair of lists hL, Ri where L is the front
portion of the queue and R is the rear portion of the queue in reverse order...

Perhaps it is worth amending that comment?

主要语言
PureScript
星标
22
派生
11
平均合并
2 天 23 小时
30 天内合并 PR
1

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

purescript/purescript-catenable-lists 的其他 Issue

查看 purescript/purescript-catenable-lists 的全部 Issue

相似的 Issue

更多 Documentation Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。