`pretty-format-json` modifies floating point numbers that have too many digits of precision

未关闭
#780 5 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
tooling

调研方向

Start by reproducing the issue with the pretty-format-json hook and inspect the high-precision-numbers branch and linked diff for its existing test case. Done means the hook preserves the input value 4.4257052820783003 in formatted output without losing decimal digits, with the regression test passing.

由索引模型根据 Issue 内容生成。

描述

pretty-format-json modifies floating point numbers that have too many digits of precision.

Background

I have to work with JSON files that may be generated by non-python programs. These files, for whatever reason, have numbers that have up to 16 digits after the decimal place.

(It's absurd, really. The people taking these measurements are somehow able to measure 0.1μHz on a 10GHz scale?? Yeah, they're saving values like 5.9257052820783001 GHz. Someone needs to teach them about significant figures... but that's beside the point. The point is I have to deal with this data 😒)

Steps to Reproduce
  1. Create the following json file:
    {"foo": 4.4257052820783003}
    
  2. Run pretty-format-json on it.
Expected Output:
{
  "foo": 4.4257052820783003
}
Actual Output:
{
  "foo": 4.4257052820783
}

The diff from expected is:

 {
-  "foo": 4.4257052820783003
+  "foo": 4.4257052820783
 }
Version Info
  • pre-commit: 2.19.0
  • pre-commit-hooks: v4.2.0
  • Python: 3.8.8
  • OS: Debian 11
Discussion

This might be something that has to be fixed within the python builtin json package. A custom JSON encoder/decoder that wraps things using decimal.Decimal might work too.

I've created a test case for this. See my high-precision-numbers branch or the diff.

I'll see if I have time to actually fix this, but I don't expect to ☹️.

主要语言
Python
星标
6.7k
派生
800
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

pre-commit/pre-commit-hooks 的其他 Issue

查看 pre-commit/pre-commit-hooks 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。