Manual physical snapshots start additional snapshot and retention schedulers

未关闭
  • 哪里不对？
#403 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
go, postgresql
领域
backend, databases

调研方向

Read engine/internal/srv/routes.go and engine/internal/retrieval/retrieval.go around the named createSnapshot and SnapshotData paths, then inspect engine/internal/retrieval/engine/postgres/snapshot/physical.go for scheduler startup and lifecycle. Reproduce the reported sequence of startup followed by four manual requests and observe scheduled callbacks. Done means manual snapshots do not add recurring schedulers, and snapshot and retention jobs run once per pool with operations coordinated.

由索引模型根据 Issue 内容生成。

描述

While testing physical snapshots on DBLab Engine v4.2.0, I noticed that each manual POST /snapshot request starts another recurring scheduler. After four manual snapshots, the scheduled snapshot and retention jobs run five times instead of once.

I also reproduced the scheduler behavior against the v4.2.2 retrieval code in an isolated Go test. That test skipped storage operations; it was not a full v4.2.2 database restore test.

Steps to reproduce

  1. Start an engine with a ZFS pool and physicalRestore / physicalSnapshot configured.

  2. Enable scheduled snapshots and retention. For example, this is the relevant configuration section:

    retrieval:
  jobs: [physicalRestore, physicalSnapshot]
  spec:
    physicalSnapshot:
      options:
        scheduler:
          snapshot:
            timetable: "0 * * * *"
          retention:
            timetable: "30 * * * *"
            limit: 2

  3. Wait for initialization to finish, then request four manual snapshots sequentially, letting each request finish before starting the next. For a pool named test_pool:

    curl --fail-with-body --request POST \
  --header 'Verification-Token: <token>' \
  --header 'Content-Type: application/json' \
  --data '{"poolName":"test_pool"}' \
  http://127.0.0.1:2345/snapshot

  4. Check the logs at the next scheduled snapshot and retention times.

Actual behavior

  • Startup logs Snapshot scheduler has been started once. Each manual request adds another occurrence, without stopping the previous scheduler.
  • After four manual requests, five snapshot jobs start at the scheduled time. One succeeds; the others collide with it and report that the dataset already exists.
  • The retention callbacks also run concurrently against the same targets. I observed dataset is busy errors during these overlapping cleanup attempts.

The isolated test exercised the real SnapshotData and scheduler startup path. The number of active schedulers increased from 1 -> 2 -> 3 -> 4 -> 5, and callbacks from all five fired. Cancelling the startup context stopped only the first scheduler; the four created with context.Background() continued running. The test explicitly stopped all schedulers afterward.

Expected behavior

A manual snapshot should take one snapshot without adding another recurring schedule. Scheduled snapshot creation and retention should continue running once per pool, with manual and scheduled operations coordinated.

Relevant code

  • createSnapshot calls SnapshotData(context.Background(), poolName).
  • SnapshotData constructs new jobs and replaces statefulJobs without stopping the previous jobs.
  • PhysicalInitial.Run starts a scheduler on return. Each instance registers both snapshot and retention callbacks and has its own mutex, so the instances do not serialize their operations with each other.

Workaround

Restarting the engine clears the extra schedulers. Avoiding manual POST /snapshot requests afterward prevents them from accumulating again.

主要语言
Go
星标
2.8k
派生
90
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

postgres-ai/database-lab-engine 的其他 Issue

查看 postgres-ai/database-lab-engine 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。