Kubernetes executor direct tests fail without envtest assets

未关闭 适合新手
  • 哪里不对？
#7,013 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

@singhharsh1708 已经在做这个了。

开始于 2026年9月6日。

  • #7014 来自 @rootp1 —— 已关闭，未合并

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
76/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
go, kubernetes
领域
devops, testing-qa

调研方向

从 pkg/app/piped/executor/kubernetes/sync_test.go 开始，重点查看 TestExecutor_ensureSync 及其 envtest.Environment 设置，然后比较 Makefile 中的资产配置和 make test/go 目标。在未设置 KUBEBUILDER_ASSETS 的情况下直接运行 go test 命令。当缺少 envtest 资产时产生清晰的跳过或设置消息，同时 make test/go 仍使用已配置的资产运行测试，即表示完成。

由索引模型根据 Issue 内容生成。

描述

What happened:

Direct package-level Go tests for the Kubernetes executor are not self-contained. Running go test ./pkg/app/piped/executor/kubernetes -run TestExecutor_ensureSync -count=1 without preinstalled envtest assets fails while starting envtest.Environment with exec: "etcd": executable file not found in $PATH or fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory.

What you expected to happen:

Direct package tests should either bootstrap envtest prerequisites automatically or skip with a clear message when the assets are unavailable, instead of failing as though the executor logic is broken.

How to reproduce it:

  1. Ensure KUBEBUILDER_ASSETS is unset and no local envtest binaries are installed.
  2. Run go test ./pkg/app/piped/executor/kubernetes -run TestExecutor_ensureSync -count=1.
  3. Observe TestExecutor_ensureSync fail while envtest.Environment starts.
  4. Compare that with make test/go, which installs and exports envtest assets via setup-envtest in Makefile before running the Go tests.

Environment:

  • piped version: repository checkout on 2026-07-11 (upstream/master fetched to d720a26a during validation)
  • control-plane version: Not applicable
  • Others: reproduced locally during repository assessment

Summary

Direct Go tests for the Kubernetes executor rely on envtest binaries that are only provisioned by the Makefile wrapper.

Affected Area

pkg/app/piped/executor/kubernetes/sync_test.go, Makefile

Expected Behaviour

The test should either provision envtest requirements or skip with a clear environment-related message.

Actual Behaviour

The test fails at envtest startup when envtest binaries are not available.

Technical Evidence

  • pkg/app/piped/executor/kubernetes/sync_test.go creates envtest.Environment directly and calls Start().
  • Makefile provisions setup-envtest and exports KUBEBUILDER_ASSETS for make test/go.
  • Reproduced failure:
    • go test ./pkg/app/piped/executor/kubernetes -run TestExecutor_ensureSync -count=1
    • Error: Received unexpected error: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH

Suspected Root Cause

The test assumes envtest binaries are already available, but that prerequisite is encoded only in the Make target and not in the test itself.

Proposed Direction

Add an explicit envtest asset preflight in the test so it either uses available binaries or skips with a clear message when the environment is missing the required assets.

Acceptance Criteria

  • Direct go test on the package no longer reports a misleading functional failure when envtest assets are missing.
  • make test/go continues to run the test unchanged when envtest assets are provisioned.
  • Contributors can distinguish environmental setup issues from real executor regressions immediately.
主要语言
Go
星标
1.4k
派生
391
平均合并
4 天 1 小时
30 天内合并 PR
58

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

pipe-cd/pipecd 的其他 Issue

查看 pipe-cd/pipecd 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。