[Bug]: Guided review: “Also in this stop” files lack inline comment controls
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 62/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
- 领域
- frontend
调研方向
Start with GuideExcerpt.tsx, which enables gutter comment controls, line selection and the comment editor for highlighted excerpts. Compare it with GuideFileDiff.tsx, which renders the files under "Also in this stop" without that wiring. Done when hovering a changed line in an expanded additional file shows the + button and submits a comment through the same flow as excerpts.
由索引模型根据 Issue 内容生成。
描述
Description
When reviewing a pull request using the guide, highlighted code excerpts show a + button when hovering over a line, allowing me to add a review comment. Files listed under “Also in this stop” do not offer this control when expanded.
Steps to reproduce
- Open a pull request’s review guide.
- Navigate to a stop containing highlighted excerpts and additional files under “Also in this stop”.
- Hover over a line in a highlighted excerpt: the + comment button appears.
- Expand one of the additional files and hover over a changed line: no comment button appears.
Expected behavior
Changed lines in expanded “Also in this stop” files should support inline review comments, just like highlighted excerpts.
Actual behavior
The additional files display their diffs, but inline commenting is unavailable.
Environment
- T3 Code desktop:
0.1.10-nightly.20261113.4630 - macOS:
27.2.1(build26B131)
Investigation
GuideExcerpt.tsx enables gutter controls and line selection and connects them to the comment editor. GuideFileDiff.tsx, used for the additional files, does not have that integration.
I found no exact duplicate. Open PR #35324 touches this viewer, but its current changes do not add commenting support there.
I’d be interested in contributing a focused fix that reuses the existing commenting flow, if this limitation is unintended.
- 主要语言
- TypeScript
- 星标
- 24.8k
- 派生
- 6.4k
- 平均合并
- 59 分钟
- 30 天内合并 PR
- 418
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
pingdotgg/t3code 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
via-triage
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 半天 新手友好度 68/100
维护者通常 1 天内回复
-
Question card options show LaTeX as raw source, though the question text renders it可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
[Bug]: Settings inheritance popover shows raw slugs for branch naming, default permissions and response streaming可能已有人在做 @juliusmarminge 于 1 天前认领。 未关闭vouch:denounced
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
相似的 Issue
-
bug platform:mobile root-cause:found
难度 2/5 1-3 小时 新手友好度 72/100
openchamber/openchamber#6926 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
push-based/user-flow#356 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
Cygnux-Labs/Tracekit#827 ·
维护者通常 1 天内回复
-
www build: a refused import shows only "ENOENT scandir <outDir>", never the build-audience error未关闭kind:defect
难度 1/5 1 小时以内 新手友好度 91/100
维护者通常 1 天内回复
-
type:bug
难度 2/5 1-3 小时 新手友好度 72/100
nightgauge/nightgauge#3266 ·
维护者通常 1 天内回复