[Bug]: Icon line weight changes with icon size
维护者通常 1 天内回复
评估
调研方向
The problem is a global stroke-width rule for lucide icons under apps/web, plus per-icon overrides (1.75, 1.9, 2, 2.25) in the timeline and toast surfaces. Linked PR 36078 is already open, so review that work before starting a parallel change. Done means icons of 12, 14 and 16 px draw the same line weight in light and dark themes, which needs visual checking by someone other than the author.
由索引模型根据 Issue 内容生成。
描述
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web
Steps to reproduce
- Open the web or desktop app on main.
- Find icons of different sizes that sit together, like the sidebar header, a timeline row or a toast.
- Compare the line of a 12 px icon with a 16 px icon.
Expected behavior
Icons that sit together draw the same line weight, whatever their size.
Actual behavior
One global rule sets stroke-width: 1.75 on lucide's 24-unit grid, so the line scales with the icon:
| Icon size | Line drawn on main |
|---|---|
| 12 px | 0.88 px |
| 14 px | 1.02 px |
| 16 px | 1.17 px |
Some icons also carry one-off overrides (1.75, 1.9, 2 and 2.25). That makes timeline and toast icons heavier than their neighbors. Hand-built SVGs next to lucide icons use their own weights too.
Top is main, bottom is the fix I have ready:
I'll link the PR here. Three things to know:
- I tested and verified it by eye on most surfaces, and I made the design calls along the way (the weight, how large icons scale, which overrides go).
- One person's eyes aren't enough for a visual change this wide. Someone else needs to see it for themselves.
- It's one part of a larger set. Some places are unclear today because of color and icon choice. I'm leaving those out for scope, and because unvouched contributors can only have 3 open PRs.
Impact
Cosmetic issue
Version or commit
main @ 290182dc83
Environment
macOS 27.2. Chromium 156, Firefox 157 and WebKit 27.2.
Logs or stack traces
Screenshots, recordings, or supporting files
pair-toast-theme-light-2x.png
pair-app-light-1x.png
pair-app-light-2x.png
pair-app-dark-2x.png
Workaround
No response
- 主要语言
- TypeScript
- 星标
- 24.8k
- 派生
- 6.4k
- 平均合并
- 59 分钟
- 30 天内合并 PR
- 418
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
pingdotgg/t3code 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
via-triage
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 半天 新手友好度 68/100
维护者通常 1 天内回复
-
Question card options show LaTeX as raw source, though the question text renders it可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
[Bug]: Settings inheritance popover shows raw slugs for branch naming, default permissions and response streaming可能已有人在做 @juliusmarminge 于 1 天前认领。 未关闭vouch:denounced
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
nikoheikkila/nikoheikkila.fi#1131 ·
维护者通常 1 天内回复
-
Resources: Update work of urumqi可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 65/100
railmapgen/rmp-gallery#4176 ·
维护者通常 2 天内回复
-
GraphQL custom headers duplicate differently cased default headers可能已有人在做 @yxr-2025 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
github/forgoodfirstissue#574 ·