[Bug]: Undoing a thread action with Ctrl+Z gives no screen reader announcement
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 83/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
调研方向
从 apps/web/src/hooks/showThreadUndoNotice.ts 开始，重点查看 undo() 和 refreshNotice()，然后阅读 AppSidebarLayout.tsx 和 SidebarThreadUndoNotice.tsx 中键盘和按钮的调用位置。确认公告如何发送和取消，然后验证撤销每种受支持的线程操作时都会播报确认信息，同时现有的失败公告仍能正常工作。
由索引模型根据 Issue 内容生成。
描述
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web
Steps to reproduce
- Turn on a screen reader (NVDA, JAWS, or VoiceOver).
- Settle, snooze, archive, or unpin a thread from the sidebar. You hear "Settled 1 thread, Ctrl+Z to undo".
- Within 5 seconds, press Ctrl+Z (or activate the "Ctrl+Z to undo" button in the sidebar footer).
Expected behavior
The screen reader confirms the undo, for example "Restored 1 thread" or "Unsettled 1 thread", so you know the shortcut worked and the thread is back.
Actual behavior
Nothing is announced. The thread is restored and the visible notice fades out, but a screen reader user gets no feedback and can't tell whether Ctrl+Z did anything. Pressing it again does nothing either, so the result is silent both times.
Only a failed undo is announced, through its error toast.
Cause. undo() in showThreadUndoNotice.ts clears the notice through refreshNotice() → setNotice(null), which calls cancelAnnouncement("thread-undo-notice") and announces nothing in its place. The keyboard path (AppSidebarLayout.tsx) and the button (SidebarThreadUndoNotice.tsx) both go through undoLatestThreadAction(), so both are silent.
A possible fix is to announce() a short confirmation from the same "thread-undo-notice" source when the undo runs, reusing the action and count the notice already has (Settled, Snoozed, Unpinned, Archived, Discarded).
Related: #31667 (the old "Ctrl+Z to undo" text stays in the live region afterwards), #23653.
Impact
Minor bug or occasional failure
Version or commit
main @ 965ddc1d6c
Environment
Windows 11, NVDA. Applies to web and desktop.
- 主要语言
- TypeScript
- 星标
- 24.8k
- 派生
- 6.4k
- 平均合并
- 8 小时 26 分钟
- 30 天内合并 PR
- 133
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
pingdotgg/t3code 的其他 Issue
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
via-triage
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
pingdotgg/t3code#33044 · 1 条评论 ·
维护者通常 1 天内回复
-
via-triage
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
相似的 Issue
-
fehler
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
Azure/azure-functions-nodejs-extensions#180 ·
维护者通常 1 天内回复
-
bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 88/100
laaielichter/Threesmith#28 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
streaming-video-technology-alliance/common-media-library#611 ·
维护者通常 1 天内回复