[Bug]: "Merge stack" appears late and pushes the stack picker out from under the cursor
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 76/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
- 领域
- frontend
调研方向
阅读 apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx 第 1304 行附近和 apps/web/src/components/pullRequest/PullRequestStackMenu.tsx 第 202 行附近的代码。跟踪 stack 查询刷新时 header 的渲染方式，然后比较堆叠 PR 和单个 PR 的控件顺序。当 picker 在加载期间保持原位，且堆叠 PR 的控件遵循一致的顺序时，任务即完成。
由索引模型根据 Issue 内容生成。
描述
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web
Steps to reproduce
- Open a stacked PR you can merge. Public demo: GisTypical/t3-stack-demo (PRs 1–5 are a stack, PR 7 is a single PR).
- Pick another layer from the stack picker (
3/5). - Click the stack picker again as soon as it shows.
- Merge stack pops in, pushes the picker left, and the click opens the merge confirmation instead. This repeats on every layer switch.
Expected behavior
Header controls don't move while data loads, and stacked PRs use the same order as single PRs.
Actual behavior
| View | Header order |
|---|---|
| Single PR | [linked threads] [Merge] [Check out] [⋯] |
| Stacked PR, loading | [2/5] [linked threads] [Check out] [⋯] |
| Stacked PR, loaded | [2/5] [Merge stack] [linked threads] [Check out] [⋯] |
The picker jumps 105 px left about 0.7 s after a layer switch (1280×800). The linked-threads button also swaps sides of the merge action between single and stacked PRs.
Cause, at e923627:
- Merge stack only renders once the stack query is fresh (
PullRequestDetailPanel.tsx:1304), but the picker renders from cached data. The row is right-aligned, so the late button pushes the picker. PullRequestStackMenurenders Merge stack next to the picker (PullRequestStackMenu.tsx:202) instead of in the Merge slot, which is why the order differs.
Impact
Minor bug or occasional failure
Version or commit
30f4d63 (dev build); the affected files are unchanged on e923627.
Environment
Linux, Chromium, GitHub stacked PRs made with gh stack.
Screenshots, recordings, or supporting files
https://github.com/user-attachments/assets/8aef5f95-79bd-4e75-b04f-45ad603cd77b
| Single PR | Stacked, loading | Stacked, loaded |
|---|---|---|
Proposed fix
Which would you accept?
- GitHub's layout: move the stack picker to the left, next to the PR status, and render Merge stack in the Merge slot.
- Smaller: render Merge stack in the Merge slot, and keep it mounted but disabled while the stack refreshes.
Both give stacked and single PRs one header order and keep Merge stack disabled until the stack is fresh.
- 主要语言
- TypeScript
- 星标
- 24.8k
- 派生
- 6.4k
- 平均合并
- 2 小时 48 分钟
- 30 天内合并 PR
- 353
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
pingdotgg/t3code 的其他 Issue
-
Diff line counts use Indian numeral grouping on en_IN locale (inconsistent toLocaleString calls)未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
[Bug]: Sidebar "Failed" badge does not clear when the session is opened (unlike "Done")可能已有人在做 @BilalIrfanContact 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 86/100
pingdotgg/t3code#25470 · 1 条评论 ·
维护者通常 1 天内回复
相似的 Issue
-
calcite-ui-icons enhancement impact - p3 - not time sensitive needs triage
难度 2/5 1-3 小时 新手友好度 67/100
Esri/calcite-design-system#15467 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
diegosouzapw/OmniRoute#18390 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 1/5 1-3 小时 新手友好度 86/100
guilhermerodz/input-otp#157 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
davidjerleke/embla-carousel#1414 ·
维护者通常 4 天内回复