Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[Bug]: SnapShot modifier-pair shortcut label "Shift + Shift" reads as a double tap; it means hold both Shift keys

未关闭 适合新手
#21,107 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
77/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
macos, typescript
领域
desktop

调研方向

阅读 packages/contracts/src/settings.ts 和 apps/web/src/lib/snapShotShortcut.ts,issue 在其中指出了修饰键组合的标签和键帽辅助函数。检查它们的测试,并更新显示的标签,让用户能够区分左键和右键,并了解它们需要同时按下。完成标准是 Settings 标签和键帽能清楚表达这一操作,且相关测试通过。

由索引模型根据 Issue 内容生成。

描述

What happened

The default SnapShot shortcut is shown as Shift + Shift in Settings (keycaps ⇧ ⇧). I read it as "press Shift twice", like JetBrains' Search Everywhere. I double-tapped Shift for days and nothing was captured. I thought the feature was broken.

The real gesture is to hold Left Shift and Right Shift at the same time. The user guide (docs/user/snap-shot.md) says "both Shift keys together", but the Settings UI does not.

Diagnosis
  • Settings has snapShotShortcut: {"kind":"both-shift-keys"}.
  • On macOS, MacModifierPairShortcutProcess polls CGEventSourceFlagsState and triggers only when the left and right device masks are set together. A double tap never sets both, so it never fires.
  • The shortcut was registered: the osascript poller was running and permissions were fine. In about 2 weeks of desktop.trace.ndjson there were 0 desktop.snapShot.shortcutActivated spans.
  • I posted synthetic Left Shift down + Right Shift down events. One shortcutActivated span appeared and the capture reached the composer (snapShot.acknowledge succeeded). So capture works and the bug is only in how the shortcut is labelled.
  • The label comes from snapShotModifierPairLabel() (packages/contracts/src/settings.ts): ${label} + ${label}. The keycaps come from snapShotShortcutKeyLabels() (apps/web/src/lib/snapShotShortcut.ts): [label, label]. Neither says which side or that the keys are held together. The same applies to Command + Command, Ctrl + Ctrl and the other pairs.
Steps to reproduce
  1. macOS, default SnapShot settings, permissions granted.
  2. Open Settings → SnapShot. The shortcut shows ⇧ ⇧ / "Shift + Shift".
  3. Press Shift twice quickly. Nothing is captured.
  4. Hold Left Shift and press Right Shift. A capture is taken.
Suggested fix

Name each side in the label and the keycaps, for example Left Shift + Right Shift and keycaps Left ⇧ Right ⇧. Optionally add a hint such as "hold both together". A local patch to snapShotModifierPairLabel and snapShotShortcutKeyLabels plus their tests is about 7 lines. I can open a PR with before/after screenshots if maintainers agree with the wording.

Version

T3 Code (Beta) 0.1.0 desktop

Environment

macOS 27.0.1, Apple Silicon

Related issues

#12769 (SnapShots trigger while typing) is about false triggers; this one is about the shortcut being unreadable, so it never triggers.

Filed by

claude (opus-5.5) via Claude Code, investigating on the user's machine

主要语言
TypeScript
星标
24.8k
派生
6.4k
平均合并
10 小时 8 分钟
30 天内合并 PR
323

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

pingdotgg/t3code 的其他 Issue

查看 pingdotgg/t3code 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。