[Rule idea] Prevent injecting the ValidatorInterface in classes extending ConstraintValidator
还没有人认领这个 Issue。
评估
调研方向
No file or test is named. Start by locating the rule definitions and tests for classes implementing ConstraintValidatorInterface, then verify how constructor injection and #[Required] methods are represented; done means reporting ValidatorInterface injection in those classes without flagging other consumers.
由索引模型根据 Issue 内容生成。
描述
Sometimes (for advanced cases), it is useful to execute validation of other constraints in the implementation of a ConstraintValidator.
The supported way of doing that in symfony/validator is to use $this->context->getValidator() (following the usage described in https://github.com/symfony/symfony/blob/v7.3.0/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php#L21-L58).
When providing support on the Symfony Slack, I encountered a case where a dev has injected the ValidatorInterface in the constraint instead and uses that. This broke everything because the main validator (entrypoint of the component) is injecting its current execution context in all the registered constraint validator, which will impact the in-progress validation when starting a new one (constraint validators will not attach all their violations to the new execution context even when not expected).
A static analysis rule could prevent such mistake by detecting places where we inject the Symfony\Component\Validator\Validator\ValidatorInterface (either through the constructor or through a method that has the #[Required] attribute of symfony/service-contracts) in a class implementing Symfony\Component\Validator\ConstraintValidatorInterface.
- 主要语言
- PHP
- 星标
- 806
- 派生
- 105
- 平均合并
- 1 小时 55 分钟
- 30 天内合并 PR
- 6
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
phpstan/phpstan-symfony 的其他 Issue
-
`ParameterBag::keys()` stub not applied for Symfony ≥ 7.4 → false-positive `is_string()` `alwaysNarrowedType`可能已有人在做 @ChrisAbner 于 4 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
phpstan/phpstan-symfony#510 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
phpstan/phpstan-symfony#494 · 5 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
phpstan/phpstan-symfony#268 ·
-
Account for `\ErrorException` from `unserialize()` when Symfony’s PHP error conversion is enabled未关闭
难度 3/5 1-2 天 新手友好度 45/100
phpstan/phpstan-symfony#514 · 2 条评论 ·
-
难度 5/5 一周以上 新手友好度 35/100
phpstan/phpstan-symfony#509 · 2 条评论 ·
查看 phpstan/phpstan-symfony 的全部 Issue
相似的 Issue
-
[Python] Worker.close() spins at 100% CPU when its teardown task is canceled可能已有人在做 @Glutexo 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
taskforcesh/bullmq#5053 ·
维护者通常 1 天内回复
-
Prerender check returns HTTP 500 when the request URI or Referer header is longer than PHP_MAXPATHLEN可能已有人在做 @lbajsarowicz 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
-
security/tailscale: add description to restart service可能已有人在做 @drpsyko101 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
Unleash/unleash-php-sdk#264 ·
-
难度 2/5 1-3 小时 新手友好度 85/100