Predicate fluent methods accept identifier types their predicates reject
维护者通常 1 天内回复
评估
调研方向
Start with the fluent methods in src/Sql/Predicate/Predicate.php and the corresponding constructors in Between.php, Operator.php, In.php, IsNull.php, and Like.php; compare their identifier parameter types. Read docs/book/sql/where-having.md and inspect the predicate tests to find where method signatures are covered. Done means the fluent signatures and API documentation match the constructors, with a test preventing future drift; linked pull request #224 is already open.
由索引模型根据 Issue 内容生成。
描述
Package Version
0.6.x-dev @ e022af5c
Php Version
8.3, 8.4, 8.5
Database Engine
Any
Basic Information
The fluent methods on Predicate\Predicate (and so on Where and Having) accept wider identifier types than the predicate classes they build. Each method passes its identifier straight to a constructor that rejects the extra types:
| Method | Identifier accepted | Constructor accepts |
|---|---|---|
between(), notBetween() (Predicate.php#L33) |
float|int|string|array|ArgumentInterface|null, plus array for min/max |
Between: string|ArgumentInterface|null (Between.php#L27) |
equalTo() and the other comparisons (Predicate.php#L50) |
float|int|string|ArgumentInterface|null |
Operator left: string|ArgumentInterface|ExpressionInterface|SqlInterface|null (Operator.php#L50) |
in(), notIn() (Predicate.php#L128) |
float|int|string|ArgumentInterface |
In: string|ArgumentInterface|null (In.php#L25) |
isNull(), isNotNull() (Predicate.php#L160) |
float|int|string|ArgumentInterface |
IsNull: string|ArgumentInterface|null (IsNull.php#L22) |
like(), notLike() (Predicate.php#L210) |
float|int|string|ArgumentInterface|null |
Like: string|ArgumentInterface|null (Like.php#L23) |
The leaf constructors were narrowed in #87 (review: "It could simply be string|Argument $identifier = null"); the fluent methods kept the wider types. docs/book/sql/where-having.md documents the wider signatures. It also states that $leftType/$rightType were removed and that a value on the left should be passed as an Argument instance.
Steps to Reproduce
(new Where())->isNull(5)(new Where())->equalTo(1, 2)(new Where())->between(['a'], 1, 2)(new Where())->in(5, [1])
Expected Behavior
Each fluent method accepts exactly what its predicate accepts, so an invalid call fails at the method the caller wrote. A numeric value on the left is passed as new Argument\Value(5), as the docs describe. The API listing in where-having.md should match.
Narrowing does not break working code, because every call it rejects already throws. A test comparing each method's parameter types with its predicate's constructor would stop them drifting apart again.
Actual behavior?
TypeError: PhpDb\Sql\Predicate\IsNull::__construct(): Argument #1 ($identifier) must be of type PhpDb\Sql\ArgumentInterface|string|null, int given
TypeError: PhpDb\Sql\Predicate\Operator::__construct(): Argument #1 ($left) must be of type PhpDb\Sql\ArgumentInterface|PhpDb\Sql\ExpressionInterface|PhpDb\Sql\SqlInterface|string|null, int given
TypeError: PhpDb\Sql\Predicate\Between::__construct(): Argument #1 ($identifier) must be of type PhpDb\Sql\ArgumentInterface|string|null, array given
TypeError: PhpDb\Sql\Predicate\In::__construct(): Argument #1 ($identifier) must be of type PhpDb\Sql\ArgumentInterface|string|null, int given
Additional Info
The unmerged 0.5.x-benchmarking branch restores $leftType/$rightType as a deprecated compatibility layer (75987ac2). If that is ever ported, the left parameter would need to accept a numeric value again, alongside a type.
- 主要语言
- PHP
- 星标
- 18
- 派生
- 8
- 平均合并
- 6 天 11 小时
- 30 天内合并 PR
- 14
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
php-db/phpdb 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
RFC
难度 3/5 1-2 天 新手友好度 66/100
维护者通常 1 天内回复
-
RFC
难度 5/5 一周以上 新手友好度 38/100
维护者通常 1 天内回复
-
RFC
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
RFC
难度 4/5 3-5 天 新手友好度 45/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
customer-support needs-triage Platform(Default)
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
grokability/snipe-it#19767 ·
维护者通常 1 天内回复
-
[Code Quality] SfxDownloader extract path has no destination-writability pre-check for cached zips未关闭priority:low type:refactor
难度 2/5 1-3 小时 新手友好度 84/100
crazy-goat/workerman-bundle#1052 ·
维护者通常 1 天内回复
-
sync-en
难度 1/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复