Should the Announcer and UtteranceQueue both have an enabledProperty?
还没有人认领这个 Issue。
评估
这个 Issue 还没有评估数据。
描述
In https://github.com/phetsims/utterance-queue/issues/58 @zepumph said
Basically here are the control Properties that we have to keep track of:
UtteranceQueue.muted
UtteranceQueue.enabledProperty
SpeechSynthesisAnnouncer.enabledProperty
SpeechSynthesisAnnouncer.canSpeakProperty
With joist (thus our sims) kinda taking its pick as to what to set during different things, it is really hard for me to see the full picture, and thus what could be the best and simplest implementation. It is a work in progress, and one that relates to our conversation from a Friday past about creating a preferences model. Do you feel this tension, or am I overreacting? (those are your only two options. . . . )
I said
I did not feel the tension but see it now that you mention it. I don't think this relates to to canSpeakProperty (A private DerivedProperty) but I see it as confusing that we have an enabledProperty on both the UtteranceQueue and the Announcer. I could see us making the enabledProperty of the Announcer utterance-queueu internal.
It seems to me that all should go through the utteranceQueue. If the Announcer is disabled, that should be utterance-queue internal.
- 主要语言
- TypeScript
- 星标
- 1
- 派生
- 5
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
phetsims/utterance-queue 的其他 Issue
-
难度 5/5 一周以上 新手友好度 30/100
phetsims/utterance-queue#125 ·
-
phetsims/utterance-queue#122 · 2 条评论 · 已指派 1 人 ·
-
phetsims/utterance-queue#121 · 已指派 1 人 ·
-
phetsims/utterance-queue#120 · 已指派 1 人 ·
-
dev:voicing type:i18n
难度 5/5 一周以上 新手友好度 25/100
phetsims/utterance-queue#119 · 1 条评论 ·
查看 phetsims/utterance-queue 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
bcgov/bc-wallet-mobile#4761 · 1 条评论 ·
-
external-issue to-triage
难度 2/5 1-3 小时 新手友好度 88/100
-
area-deployment area-integrations triage:bot-seen
难度 2/5 半天 新手友好度 86/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
refactor
难度 2/5 1-3 小时 新手友好度 84/100