WebGLRenderer.addBlendMode() returns the previous blend mode's index (v4)

未关闭
#7,413 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
46/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript
领域
frontend, game-dev

调研方向

The issue points to WebGLRenderer.addBlendMode() and shows the faulty return expression, but gives no file path or test location. Start by locating that method and the tests for blend mode registration. Confirm the returned index addresses the newly added mode and that setting, updating, and removing it leave the built-in XOR mode unchanged.

由索引模型根据 Issue 内容生成。

描述

Version

  • Phaser Version: 4.2.1 (also 4.0.0 and master at 02d8931)
  • Operating system: any (WebGL renderer)
  • Browser: any

Description

addBlendMode() returns one less than the index of the blend mode it adds:

var index = this.blendModes.push(WebGLBlendParametersFactory.createCombined(...)) - 1;

return index - 1;

push() - 1 is already the new index, so the first custom mode returns 27 (the built-in XOR slot) instead of 28. v3.90 had push() followed by a single return index - 1, which was correct.

Effects:

  • setBlendMode(index) uses the previous mode, so the custom one never renders.
  • updateBlendMode(index, ...) / removeBlendMode(index) change or remove the built-in XOR mode instead of the new one.

Example Test Code

const r = this.renderer;
const gl = r.gl;
const before = r.blendModes.length;                  // 28
const index = r.addBlendMode([ gl.DST_ALPHA, gl.ZERO ], gl.FUNC_ADD);
console.log(index, before);                          // 27 28, so index points at XOR, not the new mode

Additional Information

The fix is to drop the second - 1. I have it ready with tests and can open a PR if that's welcome.

主要语言
JavaScript
星标
40.7k
派生
7.2k
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

phaserjs/phaser 的其他 Issue

查看 phaserjs/phaser 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。