`Controller.paddingOverride` default prevents Glow filter from calculating framebuffer padding

未关闭
#7,242 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
javascript
领域
game-dev

调研方向

从 src/filters/Controller.js 中 paddingOverride 的初始化开始,并将其与 src/filters/Glow.js 中的 Glow.getPadding() 进行比较。使用带有透明精灵的最小复现来验证:默认情况下,Glow 的 padding 根据距离计算,同时 setPaddingOverride() 仍然支持显式覆盖。完成标准是 glow 延伸到精灵边缘之外且不会被裁剪。

由索引模型根据 Issue 内容生成。

描述

Version

  • Phaser Version: 4.0.0 RC6
  • Operating system: Linux
  • Browser: Chrome 133

Description

The Controller base class initializes paddingOverride to new Rectangle() (Controller.js:67), which is a zero-valued but truthy object.

The Glow filter overrides getPadding() and checks if (this.paddingOverride) before falling through to its own distance-based padding calculation (Glow.js:218). Since paddingOverride is always truthy, the Glow's distance * scale calculation never executes, and the framebuffer gets zero extra padding.

Expected: Glow extends beyond the sprite outline by distance pixels, following the alpha edges of the opaque pixels.

Actual: Glow is confined within the sprite's rectangular bounds and abruptly cuts off at the frame edges. The effect looks like a square gradient that stops at the sprite frame boundary.

Example Test Code

// Minimal reproduction
const config = {
    type: Phaser.AUTO,
    width: 400,
    height: 300,
    backgroundColor: '#2d2d2d',
    scene: {
        preload: function () {
            // Use any sprite with transparency (non-rectangular shape)
            this.load.image('star', 'https://labs.phaser.io/assets/sprites/star.png');
        },
        create: function () {
            const sprite = this.add.sprite(200, 150, 'star');
            sprite.enableFilters();
            const glow = sprite.filters.internal.addGlow(0xffff00, 4, 0, 1, false, 10, 16);

            // BUG: glow is clipped to sprite's rectangular bounds
            // WORKAROUND: uncomment the next line to fix it
            // glow.setPaddingOverride(null);
        }
    }
};

new Phaser.Game(config);

Additional Information

Root cause: Controller.js:67 sets this.paddingOverride = new Rectangle(). This zero-valued Rectangle is always truthy, so when Glow.getPadding() checks if (this.paddingOverride), it always takes the override path and returns zero padding instead of calculating distance * scale.

Workaround:

glow.setPaddingOverride(null);

Suggested fix: In Controller.js:67, change:

this.paddingOverride = new Rectangle();

to:

this.paddingOverride = null;

This lets filters with custom getPadding() implementations (Glow, Blur) fall through to their own padding logic by default. setPaddingOverride() can still be called explicitly when an override is desired.

This likely affects any filter that overrides getPadding() with a truthy check on paddingOverride.

主要语言
JavaScript
星标
40.7k
派生
7.2k
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

phaserjs/phaser 的其他 Issue

查看 phaserjs/phaser 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。