Line-ending check: catch UTF-16 text that Git treats as binary

未关闭
#57 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
62/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
git, python
领域
devtools

调研方向

Start with tools/ci/check_line_endings.py and the output of git ls-files --eol, which the script already relies on to classify files as i/crlf, i/mixed or i/-text. For entries reported as i/-text whose extension is not a real binary type, read the first bytes and fail on a UTF-16/UTF-32 byte-order mark or on CR LF. Done when a temporary git repository test shows the script failing for a UTF-16 CR LF .txt file and passing for a .png.

由索引模型根据 Issue 内容生成。

描述

area: build-ci build

tools/ci/check_line_endings.py rejects files that git ls-files --eol reports as i/crlf or i/mixed. A file Git classifies as binary by content is reported as i/-text and passes, and that includes UTF-16 text (every ASCII character is followed by a NUL byte), with CR LF inside. Windows PowerShell 5.1 writes UTF-16 with CR LF by default (> and Out-File), so such a file is easy to commit by accident.

Nothing breaks today: the maps and vectors whose bytes matter are checked by SHA-256 in their own tests. It is only the UTF-8 / LF convention that can slip.

To do

  • For i/-text entries whose extension is not on a short list of real binary types, read the first bytes and fail on a UTF-16 / UTF-32 byte-order mark or on CR LF.
  • A CPU test: a temporary git repository with a UTF-16 CR LF .txt and a .png; the script must fail for the first file only.
主要语言
C++
星标
12
派生
2
平均合并
3 小时 10 分钟
30 天内合并 PR
171

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。