Under Proton (RADV/ACO), three Model M kernels go over the 192-VGPR bound
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 15/100
- Issue 类型
- 缺陷
- 描述清晰度
- 需要澄清
- 活跃度
- 活跃
- 技术栈
- cpp
调研方向
The issue asks for a maintainer decision, not a code change: restructure the kernels, report the SPIR-V to Mesa ACO, or leave it. Start with clean/dx12/vgpr_limits.json and clean/dx12/README.md, then the kernels under clean/dx12/kernels built by build_dx12.py. Reproducing the VGPR counts needs RADV_DEBUG=shaderstats under Wine with native_direct_test. Done means a chosen path, agreed with the maintainer, and no code change to the kernels has been made yet.
由索引模型根据 Issue 内容生成。
描述
What
Under Proton, Mesa's ACO compiler needs more VGPRs than clean/dx12/vgpr_limits.json allows for three of Model M's heaviest kernels. Per vgpr_limits.json's own note, they then fit one 256-lane workgroup per CU instead of two:
| Kernel | VGPRs under ACO | Bound | Waves/SIMD | GPU time per frame |
|---|---|---|---|---|
swin_block_c64_nc |
240 | 192 | 6 | 0.30 ms |
swin_block_c96_pm_rev_nc |
256 | 192 | 5 | 0.26 ms |
bneck/swin_bneck6_mbo_nc |
256 | 192 | 5 | 0.43 ms |
swin_block_c96_add_xe_xo_nc |
192 | 192 | 8 | 0.21 ms |
d1p12/swin_block_c64_add_dec0_nc |
192 | 192 | 8 | 0.43 ms |
That's about 1.0 ms of Model M's roughly 2.3 ms on the direct route, at 1706×960 → 2560×1440. The repository's notes put a lost workgroup per CU at +38 µs (swin_block_c96_add_xe_* at 215 VGPRs) to +103 µs (dec0 at 201/215 VGPRs) per frame at 1440p Quality. So this is probably a few tenths of a millisecond on Linux. I haven't measured that directly: I can't force ACO to 192 VGPRs to compare.
It isn't loop unrolling. That was my first guess, because of the "unroll loops despite [loop]" note in clean/dx12/README.md, so I checked:
swin_block_c64_nc's DXIL has no loops at all: DXC already unrolled it, so AMD's Windows compiler gets the same straight-line code and fits it in ≤192 VGPRs (the build's RGA check).swin_block_c96_pm_rev_ncand the bottleneck keep their loops under ACO (2 and 8 back-edges).
So it's ACO's register allocation on these large kernels. Before scheduling it's already about 198 VGPRs for c64, and 194 and 230 for the other two.
How it was measured (synthetic data only)
- RX 9070 XT, Mesa RADV 27.0.0-devel, GE-Proton 11-11's Wine, vkd3d-proton
5b1089c8with dxil-spirv #362 (dxil-spirv114e664eplus the PR). - Kernels built from main's
clean/dx12/kernels(unchanged since a8500cb) withbuild_dx12.py. native_direct_test(direct route, check mode, 3 frames) run under Wine withRADV_DEBUG=shaderstats(VGPRs, waves, LDS) andRADV_DEBUG=shaders(ACO's ISA).- Kernels matched by their WMMA count: each SPIR-V cooperative-matrix multiply-add becomes two
v_wmmain ACO's ISA (736, 560 and 1312 for the three), and by LDS size where that could be read. - GPU times are from
WG_D3D12_PROFILEin the same harness. Profiling adds overhead, so treat them as rough.
What could be done (your call):
- Restructure these kernels so they need fewer registers on any compiler. That would change the Windows DXIL too.
- Report it to Mesa (ACO) with these kernels' SPIR-V as a reproducer. They're WrongGPU's own MIT-licensed code, so the SPIR-V can be shared. I can put that together if you'd rather it went that way.
- Leave it. On Linux this is a few tenths of a millisecond, not a correctness problem.
Related: #29, #10.
- 主要语言
- C++
- 星标
- 12
- 派生
- 2
- 平均合并
- 3 小时 10 分钟
- 30 天内合并 PR
- 171
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
phantoslayer21/wronggpu 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
phantoslayer21/wronggpu#275 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
phantoslayer21/wronggpu#274 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
phantoslayer21/wronggpu#241 ·
维护者通常 1 天内回复
-
bug build
难度 2/5 1-3 小时 新手友好度 74/100
phantoslayer21/wronggpu#234 ·
维护者通常 1 天内回复
-
bug build
难度 2/5 1-3 小时 新手友好度 80/100
phantoslayer21/wronggpu#233 ·
维护者通常 1 天内回复
查看 phantoslayer21/wronggpu 的全部 Issue
相似的 Issue
-
ai_p2
难度 2/5 1-3 小时 新手友好度 80/100
ClickHouse/ClickHouse#132519 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
juce-framework/JUCE#1810 ·
-
难度 1/5 1 小时以内 新手友好度 82/100
petercorke/robotics-toolbox-python#952 ·
维护者通常 1 天内回复
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit status未关闭func:engine type:bug
难度 2/5 1-3 小时 新手友好度 72/100
NatronGitHub/Natron#1276 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复