[Snap] Show actionable warning when password-manager-service is not connected instead of falling back to master password silently

未关闭
#9,919 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
python
领域
desktop, security

调研方向

Start in master_password.py at the NoKeyringError catch and follow how the master-password prompt is surfaced; reproduce the documented snap installation with the password-manager-service interface disconnected. Done means the unavailable keyring is explained, the snap command is suggested where applicable, and the master-password fallback is clearly identified.

由索引模型根据 Issue 内容生成。

描述

Feature

Describe the bug / feature request

When pgAdmin 4 is installed via snap and the password-manager-service
interface is not connected, pgAdmin silently falls back to requiring a
master password with no explanation why.

Since pgAdmin 7.2+, the OS keyring is the default and preferred storage
for saved passwords in desktop mode. However, snap's strict confinement
prevents keyring access unless the user explicitly runs:

snap connect pgadmin4:password-manager-service

This is not documented anywhere in the app, and most users will never
find it. The only hint is in the pgadmin4-snap GitHub README, which most
users never read.

Expected behavior

When pgAdmin detects that the OS keyring is unavailable (e.g.
NoKeyringError), it should:

  1. Show a clear, user-friendly message explaining that the system keyring
    is not accessible
  2. On Linux snap installs specifically, suggest the fix:
    snap connect pgadmin4:password-manager-service
  3. Offer master password as a fallback option with explanation

Current behavior

pgAdmin silently falls back to prompting for a master password with no
explanation, leading users to spend significant time trying to disable
the master password via config files (which is impossible to do via
config_local.py on snap due to read-only filesystem and snap Python path
isolation).

Steps to reproduce

  1. Install pgAdmin via snap: sudo snap install pgadmin4
  2. Open pgAdmin
  3. Observe master password prompt with no explanation

Fix

The fix in master_password.py where NoKeyringError is caught could
be extended to surface a user-facing message. Additionally, requesting
auto-connect approval from the Snap Store team for the
password-manager-service interface would solve this entirely.

Environment

  • OS: Ubuntu (snap install)
  • pgAdmin version: 9.14
  • Package type: Snap
主要语言
Python
星标
3.9k
派生
918
平均合并
2 天 12 小时
30 天内合并 PR
35

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

pgadmin-org/pgadmin4 的其他 Issue

查看 pgadmin-org/pgadmin4 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。